You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2014/01/17 01:24:22 UTC

Review Request 16998: [OOZIE-1671] add an option to limit # of coordinator actions for log retrieval

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16998/
-----------------------------------------------------------

Review request for oozie.


Bugs: OOZIE-1671
    https://issues.apache.org/jira/browse/OOZIE-1671


Repository: oozie-git


Description
-------

https://issues.apache.org/jira/browse/OOZIE-1671


Diffs
-----

  core/src/main/java/org/apache/oozie/CoordinatorEngine.java 57587c2 
  core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java a29a07e 

Diff: https://reviews.apache.org/r/16998/diff/


Testing
-------


Thanks,

Ryota Egashira

Re: Review Request 16998: [OOZIE-1671] add an option to limit # of coordinator actions for log retrieval

Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16998/#review32636
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/16998/#comment61525>

    No need for looping, you can get size of list and validate.



core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/16998/#comment61526>

    No need for looping, you can get size of set and validate.



core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java
<https://reviews.apache.org/r/16998/#comment61522>

    Minor comment.
    
    In almost all case we throw ErrorCode E0302.
    
    It good to validate error message as well, to make sure that it's failing for right reason.
    
    



webapp/src/main/webapp/oozie-console.js
<https://reviews.apache.org/r/16998/#comment61521>

    Max count is hardcoded here. Change is conf file doesn't reflect here.


- Purshotam Shah


On Jan. 23, 2014, 5:39 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16998/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2014, 5:39 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1671
>     https://issues.apache.org/jira/browse/OOZIE-1671
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1671
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/CoordinatorEngine.java 57587c2 
>   core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java a29a07e 
>   webapp/src/main/webapp/oozie-console.js 7999d35 
> 
> Diff: https://reviews.apache.org/r/16998/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 16998: [OOZIE-1671] add an option to limit # of coordinator actions for log retrieval

Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16998/#review32738
-----------------------------------------------------------


Minor comment, you fix it after rebasing with OOZIE-1668 patch.


core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/16998/#comment61698>

    We don't need maxNumActionsForLog variable always.
    
    Can you make it static or move it streamLog function( after scope verification).
    
    
    
     
    
    



core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java
<https://reviews.apache.org/r/16998/#comment61692>

    fix tab.


- Purshotam Shah


On Jan. 24, 2014, 6:12 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16998/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 6:12 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1671
>     https://issues.apache.org/jira/browse/OOZIE-1671
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1671
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/CoordinatorEngine.java 57587c2 
>   core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java a29a07e 
>   webapp/src/main/webapp/oozie-console.js 7999d35 
> 
> Diff: https://reviews.apache.org/r/16998/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>

Re: Review Request 16998: [OOZIE-1671] add an option to limit # of coordinator actions for log retrieval

Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16998/
-----------------------------------------------------------

(Updated Jan. 24, 2014, 6:12 p.m.)


Review request for oozie.


Changes
-------

fixed puru's comments. thanks


Bugs: OOZIE-1671
    https://issues.apache.org/jira/browse/OOZIE-1671


Repository: oozie-git


Description
-------

https://issues.apache.org/jira/browse/OOZIE-1671


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/CoordinatorEngine.java 57587c2 
  core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java a29a07e 
  webapp/src/main/webapp/oozie-console.js 7999d35 

Diff: https://reviews.apache.org/r/16998/diff/


Testing
-------


Thanks,

Ryota Egashira

Re: Review Request 16998: [OOZIE-1671] add an option to limit # of coordinator actions for log retrieval

Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16998/
-----------------------------------------------------------

(Updated Jan. 23, 2014, 5:39 p.m.)


Review request for oozie.


Changes
-------

added error messages.
editing the same test case with OOZIE-1668, this patch will be rebased after that patch in.


Bugs: OOZIE-1671
    https://issues.apache.org/jira/browse/OOZIE-1671


Repository: oozie-git


Description
-------

https://issues.apache.org/jira/browse/OOZIE-1671


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/CoordinatorEngine.java 57587c2 
  core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java a29a07e 
  webapp/src/main/webapp/oozie-console.js 7999d35 

Diff: https://reviews.apache.org/r/16998/diff/


Testing
-------


Thanks,

Ryota Egashira