You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "jerpelea (via GitHub)" <gi...@apache.org> on 2023/07/07 05:01:45 UTC

[GitHub] [nuttx] jerpelea opened a new pull request, #9725: arch: cxd56xx: Fix bug when watchdog restart

jerpelea opened a new pull request, #9725:
URL: https://github.com/apache/nuttx/pull/9725

   ## Summary
   Fix a bug that watchdog is expired in less time than the specified time when restarting without clearing interrupt.
   
   ## Impact
   RELEASE
   
   ## Testing
   NONE
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #9725: arch: cxd56xx: Fix bug when watchdog restart

Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #9725:
URL: https://github.com/apache/nuttx/pull/9725#discussion_r1255249932


##########
arch/arm/src/cxd56xx/cxd56_wdt.c:
##########
@@ -200,7 +200,7 @@ static uint32_t cxd56_getreg(uintptr_t regaddr)
 
   /* Show the register value read */
 
-  wdinfo("%08x->%08\n", regaddr, regval);
+  wdinfo("%08x->%08x\n", regaddr, regval);

Review Comment:
   Maybe PRIx32?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] jerpelea commented on a diff in pull request #9725: {BP-9697} arch: cxd56xx: Fix bug when watchdog restart

Posted by "jerpelea (via GitHub)" <gi...@apache.org>.
jerpelea commented on code in PR #9725:
URL: https://github.com/apache/nuttx/pull/9725#discussion_r1255251343


##########
arch/arm/src/cxd56xx/cxd56_wdt.c:
##########
@@ -200,7 +200,7 @@ static uint32_t cxd56_getreg(uintptr_t regaddr)
 
   /* Show the register value read */
 
-  wdinfo("%08x->%08\n", regaddr, regval);
+  wdinfo("%08x->%08x\n", regaddr, regval);

Review Comment:
   BP-9697



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] pkarashchenko merged pull request #9725: {BP-9697} arch: cxd56xx: Fix bug when watchdog restart

Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko merged PR #9725:
URL: https://github.com/apache/nuttx/pull/9725


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org