You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@dubbo.apache.org by yuhang xiu <ca...@gmail.com> on 2018/07/23 07:34:11 UTC

Optimize init LoadBalance in cluster invokers

Hi community,

I sent a new pr[1] to optimize init LoadBalance in cluster invokers.
The LoadBalance will init anyway now, but the
AvailableCluster、AvailableClusterInvoker、BroadcastClusterInvoker
do not need to init a LoadBalance because they will never use it.

So the control of init LoadBalance should sink to ClusterInvokers themself.

And also, the pr make LoadBalance init before 'doInvoke' method called.

[1] https://github.com/apache/incubator-dubbo/pull/2109

Re: Optimize init LoadBalance in cluster invokers

Posted by yuhang xiu <ca...@gmail.com>.

Ok.
Thx  :)

2018-07-25 17:30 GMT+08:00 Ian Luo <ia...@gmail.com>:

> cool, we will take a look, and let's discuss on that PR.
>
> Thanks,
> -Ian.
>
> On Mon, Jul 23, 2018 at 3:34 PM yuhang xiu <ca...@gmail.com> wrote:
>
> > Hi community,
> >
> > I sent a new pr[1] to optimize init LoadBalance in cluster invokers.
> > The LoadBalance will init anyway now, but the
> > AvailableCluster、AvailableClusterInvoker、BroadcastClusterInvoker
> > do not need to init a LoadBalance because they will never use it.
> >
> > So the control of init LoadBalance should sink to ClusterInvokers
> themself.
> >
> > And also, the pr make LoadBalance init before 'doInvoke' method called.
> >
> > [1] https://github.com/apache/incubator-dubbo/pull/2109
> >
>

Re: Optimize init LoadBalance in cluster invokers

Posted by Ian Luo <ia...@gmail.com>.

cool, we will take a look, and let's discuss on that PR.

Thanks,
-Ian.

On Mon, Jul 23, 2018 at 3:34 PM yuhang xiu <ca...@gmail.com> wrote:

> Hi community,
>
> I sent a new pr[1] to optimize init LoadBalance in cluster invokers.
> The LoadBalance will init anyway now, but the
> AvailableCluster、AvailableClusterInvoker、BroadcastClusterInvoker
> do not need to init a LoadBalance because they will never use it.
>
> So the control of init LoadBalance should sink to ClusterInvokers themself.
>
> And also, the pr make LoadBalance init before 'doInvoke' method called.
>
> [1] https://github.com/apache/incubator-dubbo/pull/2109
>