[GitHub] [incubator-pekko] He-Pin commented on a diff in pull request #31: =str Fix `CompletionStage#toCompletableFuture` may throw Exception

[GitBox <gi...@apache.org>]

He-Pin commented on code in PR #31:
URL: https://github.com/apache/incubator-pekko/pull/31#discussion_r1016120111


##########
akka-stream/src/main/scala/akka/stream/impl/Unfold.scala:
##########
@@ -113,20 +114,21 @@ import scala.util.{ Failure, Success, Try }
       }
 
       def onPull(): Unit = {
-        val future = f.apply(state).toCompletableFuture

Review Comment:
   `.toCompletableFuture` which may throw exception, now fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org