[GitHub] [superset] rusackas commented on a change in pull request #12920: refactor: Bootstrap to AntD - Collapse

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #12920:
URL: https://github.com/apache/superset/pull/12920#discussion_r569789056



##########
File path: superset-frontend/src/explore/components/controls/FixedOrMetricControl.jsx
##########
@@ -107,67 +100,83 @@ export default class FixedOrMetricControl extends React.Component {
     return (
       <div>
         <ControlHeader {...this.props} />
-        <Label onClick={this.toggle}>
-          {this.state.type === controlTypes.fixed && (
-            <span>{this.state.fixedValue}</span>
-          )}
-          {this.state.type === controlTypes.metric && (
-            <span>
-              <span style={{ fontWeight: 'normal' }}>metric: </span>
-              <strong>
-                {this.state.metricValue ? this.state.metricValue.label : null}
-              </strong>
-            </span>
-          )}
-        </Label>
-        <Panel
-          className="panel-spreaded"
-          collapsible
-          expanded={this.state.expanded}
-          onToggle={this.toggle}
+        <Collapse
+          ghost
+          css={css`
+            .ant-collapse-header {
+              border: 0px !important;
+              padding: 0px 0px 8px 0px !important;

Review comment:
       I've used the `&`*n trick a few times with success. It might get a little out of hand in some cases, but is definitely better than `!important` - it's also worth noting that IDs count for a lot more than classes in CSS selectors, if there are any that can be leveraged. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org