You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by laimis <gi...@git.apache.org> on 2015/01/31 22:20:59 UTC

[GitHub] lucenenet pull request: fix LogMergePolicy IsMerged logic

GitHub user laimis opened a pull request:

    https://github.com/apache/lucenenet/pull/65

    fix LogMergePolicy IsMerged logic

    This fixes the issue where if LogByteSizeMergePolicy is used, the merges run "forever". At the end of the day the issue was not with the byte size policy, but with the LogMergePolicy "IsMerged" logic. segmentIsOriginal check was inverted, forcing the evaluation to continue and check IsMerged on already merged index and for LogByteSizeMergePolicy that returned false when in reality that check should have never happened. Changed the code to match Lucene:
    
    https://github.com/apache/lucene-solr/blob/lucene_solr_4_8_0/lucene/core/src/java/org/apache/lucene/index/LogMergePolicy.java#L181

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laimis/lucenenet log_merge_polixy_fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucenenet/pull/65.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #65
    
----
commit 2c566585cb1784a3ab5ea07bf2e349397c93f590
Author: Laimonas Simutis <la...@gmail.com>
Date:   2015-01-31T21:14:41Z

    fix LogMergePolicy IsMerged logic

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] lucenenet pull request: fix LogMergePolicy IsMerged logic

Posted by synhershko <gi...@git.apache.org>.
Github user synhershko commented on the pull request:

    https://github.com/apache/lucenenet/pull/65#issuecomment-72337320
  
    Good catch!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] lucenenet pull request: fix LogMergePolicy IsMerged logic

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/lucenenet/pull/65


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---