You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/06/09 16:45:39 UTC
[GitHub] [maven] gnodet opened a new pull request #477: Improve the use of checkstyle in the build
gnodet opened a new pull request #477:
URL: https://github.com/apache/maven/pull/477
This PR improves the build time wrt to checkstyle.
Two other Pas will follow to incorporate https://github.com/codehaus-plexus/modello/pull/116, https://github.com/codehaus-plexus/modello/pull/117 and https://github.com/mojohaus/animal-sniffer/pull/165 if possible.
Those 4 fixes make subsequent builds much smoother.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet merged pull request #477: Improve the use of checkstyle in the build
Posted by GitBox <gi...@apache.org>.
gnodet merged pull request #477:
URL: https://github.com/apache/maven/pull/477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet merged pull request #477: Improve the use of checkstyle in the build
Posted by GitBox <gi...@apache.org>.
gnodet merged pull request #477:
URL: https://github.com/apache/maven/pull/477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #477: Improve the use of checkstyle in the build
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #477:
URL: https://github.com/apache/maven/pull/477#discussion_r648618184
##########
File path: maven-core/src/main/java/org/apache/maven/execution/BuildResumptionAnalyzer.java
##########
@@ -32,5 +32,5 @@
* @param result Outcome of the current Maven build.
* @return A {@link BuildResumptionData} instance or {@link Optional#empty()} if resuming the build is not possible.
*/
- Optional<BuildResumptionData> determineBuildResumptionData( final MavenExecutionResult result );
+ Optional<BuildResumptionData> determineBuildResumptionData( MavenExecutionResult result );
Review comment:
Why did you remove the `final` keywords?
##########
File path: .mvn/readme.txt
##########
@@ -0,0 +1 @@
+The .mvn folder is needed to be able to use the ${maven.multiModuleProjectDirectory} property.
Review comment:
directory, not folder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #477: Improve the use of checkstyle in the build
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #477:
URL: https://github.com/apache/maven/pull/477#issuecomment-857962364
The problem with checkstyle is that using the error level as a violation means info and warnings will be ignored. Unfortunately, those are only ignored by the plugin, but checkstyle still see the violations and does not cache the results for files that contains such violations. We need to use info level and some real suppressions so that all files can be cached correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on a change in pull request #477: Improve the use of checkstyle in the build
Posted by GitBox <gi...@apache.org>.
gnodet commented on a change in pull request #477:
URL: https://github.com/apache/maven/pull/477#discussion_r648641684
##########
File path: maven-core/src/main/java/org/apache/maven/execution/BuildResumptionAnalyzer.java
##########
@@ -32,5 +32,5 @@
* @param result Outcome of the current Maven build.
* @return A {@link BuildResumptionData} instance or {@link Optional#empty()} if resuming the build is not possible.
*/
- Optional<BuildResumptionData> determineBuildResumptionData( final MavenExecutionResult result );
+ Optional<BuildResumptionData> determineBuildResumptionData( MavenExecutionResult result );
Review comment:
They break recent checkstyle rules, which makes sense because they have no meaning on method declaration afaik.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org