You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by amensiko <gi...@git.apache.org> on 2017/06/15 17:19:34 UTC

[GitHub] opennlp pull request #231: Adding sentiment analysis code to OpenNLP: OPENNL...

GitHub user amensiko opened a pull request:

    https://github.com/apache/opennlp/pull/231

    Adding sentiment analysis code to OpenNLP: OPENNLP-840

    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/amensiko/opennlp OPENNLP-840-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/opennlp/pull/231.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #231
    
----
commit 21fbd8bd15387725e546ed950f7e9cb49cd3d840
Author: Menshikova <an...@trincoll.edu>
Date:   2017-06-15T16:59:19Z

    Adding sentiment analysis code to OpenNLP: OPENNLP-840

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] opennlp pull request #231: Adding sentiment analysis code to OpenNLP: OPENNL...

Posted by Chris Mattmann <ma...@apache.org>.
Pull request looks good to me, just has Ana’s commits?

I’m going to try and it merged today thanks all.

Cheers,
Chris




On 6/15/17, 10:54 AM, "Anastasia Menshikova" <me...@gmail.com> wrote:

    Hi Daniel,
    
    I just checked and tried rebasing it, but it says that "Current branch
    master is up to date".
    
    Thank you,
    Anastasija
    
    On 15 June 2017 at 10:27, Daniel Russ <dr...@apache.org> wrote:
    
    > Hi,
    >    I tried to take a look at the pull request.  But it is 1677 commits
    > behind apache:master.  Can you please rebase your code.
    > Thank you.
    > Daniel
    >
    > > On Jun 15, 2017, at 1:19 PM, amensiko <gi...@git.apache.org> wrote:
    > >
    > > GitHub user amensiko opened a pull request:
    > >
    > >    https://github.com/apache/opennlp/pull/231
    > >
    > >    Adding sentiment analysis code to OpenNLP: OPENNLP-840
    > >
    > >
    > >
    > >
    > > You can merge this pull request into a Git repository by running:
    > >
    > >    $ git pull https://github.com/amensiko/opennlp OPENNLP-840-2
    > >
    > > Alternatively you can review and apply these changes as the patch at:
    > >
    > >    https://github.com/apache/opennlp/pull/231.patch
    > >
    > > To close this pull request, make a commit to your master/trunk branch
    > > with (at least) the following in the commit message:
    > >
    > >    This closes #231
    > >
    > > ----
    > > commit 21fbd8bd15387725e546ed950f7e9cb49cd3d840
    > > Author: Menshikova <an...@trincoll.edu>
    > > Date:   2017-06-15T16:59:19Z
    > >
    > >    Adding sentiment analysis code to OpenNLP: OPENNLP-840
    > >
    > > ----
    > >
    > >
    > > ---
    > > If your project is set up for it, you can reply to this email and have
    > your
    > > reply appear on GitHub as well. If your project does not have this
    > feature
    > > enabled and wishes so, or if the feature is enabled but not working,
    > please
    > > contact infrastructure at infrastructure@apache.org or file a JIRA
    > ticket
    > > with INFRA.
    > > ---
    >
    >
    



Re: [GitHub] opennlp pull request #231: Adding sentiment analysis code to OpenNLP: OPENNL...

Posted by Anastasia Menshikova <me...@gmail.com>.
Hi Daniel,

I just checked and tried rebasing it, but it says that "Current branch
master is up to date".

Thank you,
Anastasija

On 15 June 2017 at 10:27, Daniel Russ <dr...@apache.org> wrote:

> Hi,
>    I tried to take a look at the pull request.  But it is 1677 commits
> behind apache:master.  Can you please rebase your code.
> Thank you.
> Daniel
>
> > On Jun 15, 2017, at 1:19 PM, amensiko <gi...@git.apache.org> wrote:
> >
> > GitHub user amensiko opened a pull request:
> >
> >    https://github.com/apache/opennlp/pull/231
> >
> >    Adding sentiment analysis code to OpenNLP: OPENNLP-840
> >
> >
> >
> >
> > You can merge this pull request into a Git repository by running:
> >
> >    $ git pull https://github.com/amensiko/opennlp OPENNLP-840-2
> >
> > Alternatively you can review and apply these changes as the patch at:
> >
> >    https://github.com/apache/opennlp/pull/231.patch
> >
> > To close this pull request, make a commit to your master/trunk branch
> > with (at least) the following in the commit message:
> >
> >    This closes #231
> >
> > ----
> > commit 21fbd8bd15387725e546ed950f7e9cb49cd3d840
> > Author: Menshikova <an...@trincoll.edu>
> > Date:   2017-06-15T16:59:19Z
> >
> >    Adding sentiment analysis code to OpenNLP: OPENNLP-840
> >
> > ----
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastructure@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
>
>

Re: [GitHub] opennlp pull request #231: Adding sentiment analysis code to OpenNLP: OPENNL...

Posted by Daniel Russ <dr...@apache.org>.
Hi,
   I tried to take a look at the pull request.  But it is 1677 commits behind apache:master.  Can you please rebase your code.
Thank you.
Daniel

> On Jun 15, 2017, at 1:19 PM, amensiko <gi...@git.apache.org> wrote:
> 
> GitHub user amensiko opened a pull request:
> 
>    https://github.com/apache/opennlp/pull/231
> 
>    Adding sentiment analysis code to OpenNLP: OPENNLP-840
> 
> 
> 
> 
> You can merge this pull request into a Git repository by running:
> 
>    $ git pull https://github.com/amensiko/opennlp OPENNLP-840-2
> 
> Alternatively you can review and apply these changes as the patch at:
> 
>    https://github.com/apache/opennlp/pull/231.patch
> 
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
> 
>    This closes #231
> 
> ----
> commit 21fbd8bd15387725e546ed950f7e9cb49cd3d840
> Author: Menshikova <an...@trincoll.edu>
> Date:   2017-06-15T16:59:19Z
> 
>    Adding sentiment analysis code to OpenNLP: OPENNLP-840
> 
> ----
> 
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---


[GitHub] opennlp pull request #231: Adding sentiment analysis code to OpenNLP: OPENNL...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/opennlp/pull/231


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---