You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/31 12:39:48 UTC
[GitHub] [kafka] cadonna opened a new pull request #10449: MINOR: Fix docs for end-to-end record latency metrics
cadonna opened a new pull request #10449:
URL: https://github.com/apache/kafka/pull/10449
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #10449: MINOR: Fix docs for end-to-end record latency metrics
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #10449:
URL: https://github.com/apache/kafka/pull/10449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on a change in pull request #10449: MINOR: Fix docs for end-to-end record latency metrics
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on a change in pull request #10449:
URL: https://github.com/apache/kafka/pull/10449#discussion_r605109431
##########
File path: docs/ops.html
##########
@@ -2586,7 +2574,22 @@ <h5 class="anchor-heading"><a id="kafka_streams_node_monitoring" class="anchor-l
<td>The total number of records that have been emitted downstream from suppression operation nodes.</td>
<td>kafka.streams:type=stream-processor-node-metrics,thread-id=([-.\w]+),task-id=([-.\w]+),processor-node-id=([-.\w]+)</td>
</tr>
- </tbody>
+ <tr>
+ <td>record-e2e-latency-avg</td>
Review comment:
Ah, thanks. Tbh I had forgotten how we ultimately ended up doing these metrics, thanks for catching this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10449: MINOR: Fix docs for end-to-end record latency metrics
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10449:
URL: https://github.com/apache/kafka/pull/10449#issuecomment-811294592
Unrelated failures in `kafka.server.RaftClusterTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on a change in pull request #10449: MINOR: Fix docs for end-to-end record latency metrics
Posted by GitBox <gi...@apache.org>.
cadonna commented on a change in pull request #10449:
URL: https://github.com/apache/kafka/pull/10449#discussion_r604861687
##########
File path: docs/ops.html
##########
@@ -2586,7 +2574,22 @@ <h5 class="anchor-heading"><a id="kafka_streams_node_monitoring" class="anchor-l
<td>The total number of records that have been emitted downstream from suppression operation nodes.</td>
<td>kafka.streams:type=stream-processor-node-metrics,thread-id=([-.\w]+),task-id=([-.\w]+),processor-node-id=([-.\w]+)</td>
</tr>
- </tbody>
+ <tr>
+ <td>record-e2e-latency-avg</td>
Review comment:
Technically, the record e2e latency metrics are processor node level metrics that are only available on certain types of nodes. Since the bean regex depends on the level (i.e., the metric group) the regex was wrong before.
##########
File path: docs/ops.html
##########
@@ -2534,31 +2534,19 @@ <h5 class="anchor-heading"><a id="kafka_streams_task_monitoring" class="anchor-l
</tr>
<tr>
<td>active-process-ratio</td>
- <td>The total number of records dropped within this task.</td>
Review comment:
This fixes a copy and paste error coming from the `dropped-records-*` metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org