You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/10/13 18:10:02 UTC

[GitHub] [geode] DonalEvans commented on a change in pull request #6991: GEODE-9731: Fix flaky PubSubIntegrationTest

DonalEvans commented on a change in pull request #6991:
URL: https://github.com/apache/geode/pull/6991#discussion_r728328319



##########
File path: geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/pubsub/AbstractPubSubIntegrationTest.java
##########
@@ -714,6 +714,7 @@ public void testPatternAndRegularSubscribe() {
     subscriberThread.start();
     waitFor(() -> mockSubscriber.getSubscribedChannels() == 1);
 
+    mockSubscriber.prepareMessagesReceivedLatch(1);

Review comment:
       Should this be `preparePMessagesReceivedLatch(1)`? We're already calling `prepareMessagesReceivedLatch(1)` on line 721, and not publishing between calls, so the second call doesn't seem to be doing anything with this change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org