You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <jh...@pivotal.io> on 2016/11/29 22:43:17 UTC
Review Request 54184: Adding a test to show secondary queue is being
drained for GEODE-2123
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54184/
-----------------------------------------------------------
Review request for geode, Barry Oglesby and Dan Smith.
Repository: geode
Description
-------
Also fixed a possibly flaky test by removing the sleeps and having it check the actual size of the queue (including secondary buckets)
Removed some unnecessary sleep calls
Diffs
-----
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java 2e9fdbc
geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ConcurrentParallelGatewaySenderQueue.java 603fd6c
geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 553847d
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/WANTestBase.java f9c18ec
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java 931a49c
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationConcurrentOpsDUnitTest.java 0ce6782
Diff: https://reviews.apache.org/r/54184/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 54184: Adding a test to show secondary queue is
being drained for GEODE-2123
Posted by Jason Huynh <jh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54184/
-----------------------------------------------------------
(Updated Nov. 30, 2016, 9:18 p.m.)
Review request for geode, Barry Oglesby and Dan Smith.
Changes
-------
Modified the test to shut down one of the senders to cause the batch removal thread to shut (it no longer will with the fix for 2123).
In this diff is also a change I forgot to make before checking in 2124.
Repository: geode
Description
-------
Also fixed a possibly flaky test by removing the sleeps and having it check the actual size of the queue (including secondary buckets)
Removed some unnecessary sleep calls
Diffs (updated)
-----
geode-core/src/main/java/org/apache/geode/cache/query/internal/StructSet.java e89e123
geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java 2e9fdbc
geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ConcurrentParallelGatewaySenderQueue.java 603fd6c
geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 553847d
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/WANTestBase.java 6351933
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java 931a49c
geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationConcurrentOpsDUnitTest.java 0ce6782
Diff: https://reviews.apache.org/r/54184/diff/
Testing
-------
Thanks,
Jason Huynh
Re: Review Request 54184: Adding a test to show secondary queue is
being drained for GEODE-2123
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54184/#review157355
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On Nov. 29, 2016, 10:43 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54184/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2016, 10:43 p.m.)
>
>
> Review request for geode, Barry Oglesby and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Also fixed a possibly flaky test by removing the sleeps and having it check the actual size of the queue (including secondary buckets)
> Removed some unnecessary sleep calls
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java 2e9fdbc
> geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ConcurrentParallelGatewaySenderQueue.java 603fd6c
> geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java 553847d
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/WANTestBase.java f9c18ec
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java 931a49c
> geode-wan/src/test/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationConcurrentOpsDUnitTest.java 0ce6782
>
> Diff: https://reviews.apache.org/r/54184/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jason Huynh
>
>