You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by il...@apache.org on 2018/11/07 09:44:34 UTC
[incubator-dubbo] branch 2.6.x updated: #2748: Provider should
disable mock configuration (#2750)
This is an automated email from the ASF dual-hosted git repository.
iluo pushed a commit to branch 2.6.x
in repository https://gitbox.apache.org/repos/asf/incubator-dubbo.git
The following commit(s) were added to refs/heads/2.6.x by this push:
new d6aae07 #2748: Provider should disable mock configuration (#2750)
d6aae07 is described below
commit d6aae075b1d285ead105ce3cc6d4fdcaaaf1c42e
Author: Ian Luo <ia...@gmail.com>
AuthorDate: Wed Nov 7 17:44:27 2018 +0800
#2748: Provider should disable mock configuration (#2750)
---
.../main/java/com/alibaba/dubbo/config/ServiceConfig.java | 10 ++++++++++
.../java/com/alibaba/dubbo/config/ServiceConfigTest.java | 12 ++++++++++++
2 files changed, 22 insertions(+)
diff --git a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ServiceConfig.java b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ServiceConfig.java
index 8435db5..c02a222 100644
--- a/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ServiceConfig.java
+++ b/dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ServiceConfig.java
@@ -820,6 +820,16 @@ public class ServiceConfig<T> extends AbstractServiceConfig {
}
}
+ @Override
+ public void setMock(Boolean mock) {
+ throw new IllegalArgumentException("mock doesn't support on provider side");
+ }
+
+ @Override
+ public void setMock(String mock) {
+ throw new IllegalArgumentException("mock doesn't support on provider side");
+ }
+
public List<URL> getExportedUrls() {
return urls;
}
diff --git a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ServiceConfigTest.java b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ServiceConfigTest.java
index ed5a2e3..2765b9f 100644
--- a/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ServiceConfigTest.java
+++ b/dubbo-config/dubbo-config-api/src/test/java/com/alibaba/dubbo/config/ServiceConfigTest.java
@@ -194,6 +194,18 @@ public class ServiceConfigTest {
service.setGeneric("illegal");
}
+ @Test(expected = IllegalArgumentException.class)
+ public void testMock() throws Exception {
+ ServiceConfig service = new ServiceConfig();
+ service.setMock("true");
+ }
+
+ @Test(expected = IllegalArgumentException.class)
+ public void testMock2() throws Exception {
+ ServiceConfig service = new ServiceConfig();
+ service.setMock(true);
+ }
+
@Test
public void testUniqueServiceName() throws Exception {
ServiceConfig<Greeting> service = new ServiceConfig<Greeting>();