You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by wa...@apache.org on 2022/10/17 07:17:04 UTC

[echarts] branch fix/lines-type created (now e780ba5e7)

This is an automated email from the ASF dual-hosted git repository.

wangzx pushed a change to branch fix/lines-type
in repository https://gitbox.apache.org/repos/asf/echarts.git


      at e780ba5e7 fix(lines): add missing `function` callback into `lineStyle.color` for line series.

This branch includes the following new commits:

     new e780ba5e7 fix(lines): add missing `function` callback into `lineStyle.color` for line series.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[echarts] 01/01: fix(lines): add missing `function` callback into `lineStyle.color` for line series.

Posted by wa...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

wangzx pushed a commit to branch fix/lines-type
in repository https://gitbox.apache.org/repos/asf/echarts.git

commit e780ba5e7dbea9d549b728e37e962f3320fb8801
Author: plainheart <yh...@all-my-life.cn>
AuthorDate: Mon Oct 17 15:15:28 2022 +0800

    fix(lines): add missing `function` callback into `lineStyle.color` for line series.
    
    - remove unsupported function callback from `lineStyle.color` in states
---
 src/chart/lines/LinesSeries.ts | 6 +++---
 src/chart/lines/LinesView.ts   | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/chart/lines/LinesSeries.ts b/src/chart/lines/LinesSeries.ts
index 7b8ff2878..2c1fc29c8 100644
--- a/src/chart/lines/LinesSeries.ts
+++ b/src/chart/lines/LinesSeries.ts
@@ -93,8 +93,8 @@ export interface LinesStateOption<TCbParams = never> {
     label?: SeriesLineLabelOption
 }
 
-export interface LinesDataItemOption extends LinesStateOption<CallbackDataParams>,
-    StatesOptionMixin<LinesStateOption<CallbackDataParams>, LinesStatesMixin> {
+export interface LinesDataItemOption extends LinesStateOption,
+    StatesOptionMixin<LinesStateOption, LinesStatesMixin> {
     name?: string
 
     fromName?: string
@@ -111,7 +111,7 @@ export interface LinesDataItemOption extends LinesStateOption<CallbackDataParams
 }
 
 export interface LinesSeriesOption
-    extends SeriesOption<LinesStateOption, LinesStatesMixin>, LinesStateOption,
+    extends SeriesOption<LinesStateOption, LinesStatesMixin>, LinesStateOption<CallbackDataParams>,
     SeriesOnCartesianOptionMixin, SeriesOnGeoOptionMixin, SeriesOnPolarOptionMixin,
     SeriesOnCalendarOptionMixin, SeriesLargeOptionMixin {
 
diff --git a/src/chart/lines/LinesView.ts b/src/chart/lines/LinesView.ts
index fabb84968..5d9cbfeef 100644
--- a/src/chart/lines/LinesView.ts
+++ b/src/chart/lines/LinesView.ts
@@ -106,7 +106,7 @@ class LinesView extends ChartView {
 
         const lineDraw = this._updateLineDraw(data, seriesModel);
 
-        lineDraw.incrementalPrepareUpdate(data);
+        lineDraw.incrementalPrepareUpdate(data as any);
 
         this._clearLayer(api);
 
@@ -118,7 +118,7 @@ class LinesView extends ChartView {
         seriesModel: LinesSeriesModel,
         ecModel: GlobalModel
     ) {
-        this._lineDraw.incrementalUpdate(taskParams, seriesModel.getData());
+        this._lineDraw.incrementalUpdate(taskParams, seriesModel.getData() as any);
 
         this._finished = taskParams.end === seriesModel.getData().count();
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org