You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Farhan Khan <fa...@freestoneinfotech.com> on 2022/02/14 14:12:32 UTC

Review Request 73843: ATLAS-4553 : UI: (Classic) Columns added in search results page gets reset after clicking refresh button

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73843/
-----------------------------------------------------------

Review request for atlas and Prasad Pawar.


Bugs: ATLAS-4553
    https://issues.apache.org/jira/browse/ATLAS-4553


Repository: atlas


Description
-------

In this scenario, after a successful query made in basic search, the user decides to add more search result columns. If after this step the user clicks on the refresh button, then those added columns disappear. This behaviour is not observed in the new UI.


Diffs
-----

  dashboardv2/public/js/views/search/SearchResultLayoutView.js b98ef9ae4 


Diff: https://reviews.apache.org/r/73843/diff/1/


Testing
-------

Tested for above mentioned scenario, working as expected.


Thanks,

Farhan Khan

Re: Review Request 73843: ATLAS-4553 : UI: (Classic) Columns added in search results page gets reset after clicking refresh button

Posted by Prasad Pawar <pr...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73843/#review224158
-----------------------------------------------------------


Ship it!




Ship It!

- Prasad Pawar


On March 15, 2022, 11:25 a.m., Farhan Khan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73843/
> -----------------------------------------------------------
> 
> (Updated March 15, 2022, 11:25 a.m.)
> 
> 
> Review request for atlas and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4553
>     https://issues.apache.org/jira/browse/ATLAS-4553
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> In this scenario, after a successful query made in basic search, the user decides to add more search result columns. If after this step the user clicks on the refresh button, then those added columns disappear. And for Classification search if user tries to add more columns, then the added columns are not visible on the UI.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js b98ef9ae4 
>   dashboardv3/public/js/views/search/SearchResultLayoutView.js 9837b5aa0 
> 
> 
> Diff: https://reviews.apache.org/r/73843/diff/2/
> 
> 
> Testing
> -------
> 
> Tested for above mentioned scenario, working as expected.
> 
> 
> Thanks,
> 
> Farhan Khan
> 
>

Re: Review Request 73843: ATLAS-4553 : UI: (Classic) Columns added in search results page gets reset after clicking refresh button

Posted by Farhan Khan <fa...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73843/
-----------------------------------------------------------

(Updated March 15, 2022, 11:25 a.m.)


Review request for atlas and Prasad Pawar.


Bugs: ATLAS-4553
    https://issues.apache.org/jira/browse/ATLAS-4553


Repository: atlas


Description (updated)
-------

In this scenario, after a successful query made in basic search, the user decides to add more search result columns. If after this step the user clicks on the refresh button, then those added columns disappear. And for Classification search if user tries to add more columns, then the added columns are not visible on the UI.


Diffs (updated)
-----

  dashboardv2/public/js/views/search/SearchResultLayoutView.js b98ef9ae4 
  dashboardv3/public/js/views/search/SearchResultLayoutView.js 9837b5aa0 


Diff: https://reviews.apache.org/r/73843/diff/2/

Changes: https://reviews.apache.org/r/73843/diff/1-2/


Testing
-------

Tested for above mentioned scenario, working as expected.


Thanks,

Farhan Khan

Re: Review Request 73843: ATLAS-4553 : UI: (Classic) Columns added in search results page gets reset after clicking refresh button

Posted by Prasad Pawar <pr...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73843/#review224058
-----------------------------------------------------------


Ship it!




Ship It!

- Prasad Pawar


On Feb. 14, 2022, 2:12 p.m., Farhan Khan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73843/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2022, 2:12 p.m.)
> 
> 
> Review request for atlas and Prasad Pawar.
> 
> 
> Bugs: ATLAS-4553
>     https://issues.apache.org/jira/browse/ATLAS-4553
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> In this scenario, after a successful query made in basic search, the user decides to add more search result columns. If after this step the user clicks on the refresh button, then those added columns disappear. This behaviour is not observed in the new UI.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js b98ef9ae4 
> 
> 
> Diff: https://reviews.apache.org/r/73843/diff/1/
> 
> 
> Testing
> -------
> 
> Tested for above mentioned scenario, working as expected.
> 
> 
> Thanks,
> 
> Farhan Khan
> 
>