[GitHub] [shardingsphere] taojintianxia commented on a change in pull request #14596: Refactor DataSourceParameter

[GitBox <gi...@apache.org>]

taojintianxia commented on a change in pull request #14596:
URL: https://github.com/apache/shardingsphere/pull/14596#discussion_r780072627



##########
File path: shardingsphere-proxy/shardingsphere-proxy-bootstrap/src/test/java/org/apache/shardingsphere/proxy/config/util/DataSourceParameterConverterTest.java
##########
@@ -44,11 +44,7 @@ public void assertGetDataSourceConfigurationMap() {
     }
     
     private DataSourceParameter crateDataSourceParameter() {
-        DataSourceParameter result = new DataSourceParameter();
-        result.setUrl("jdbc:mysql://localhost:3306/demo_ds");
-        result.setUsername("root");
-        result.setPassword("root");
-        return result;
+        return new DataSourceParameter("jdbc:mysql://localhost:3306/demo_ds", "root", "root", null, null, null, null, null, null, null);

Review comment:
       ten parameters in a constructor, this is not that  elegant




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org