You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/07 04:09:44 UTC
[GitHub] [flink] bowenli86 commented on a change in pull request #11900: [FLINK-17284][jdbc][postgres] Support serial fields
bowenli86 commented on a change in pull request #11900:
URL: https://github.com/apache/flink/pull/11900#discussion_r421227400
##########
File path: flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/catalog/PostgresCatalog.java
##########
@@ -216,6 +216,12 @@ public CatalogBaseTable getTable(ObjectPath tablePath) throws TableNotExistExcep
}
}
+ public static final String PG_SERIAL = "serial";
+ //public static final String PG_SERIAL2 = "serial2"; //ResultSetMetaData.getColumnTypeName() returns int2
Review comment:
just add comments, rather than commenting out string constants?
##########
File path: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/catalog/PostgresCatalogTestBase.java
##########
@@ -58,6 +58,7 @@
protected static final String TABLE5 = "t5";
protected static final String TABLE_PRIMITIVE_TYPE = "dt";
protected static final String TABLE_ARRAY_TYPE = "dt2";
+ protected static final String TABLE_SERIAL_TYPE = "dt3";
Review comment:
why use a separate table rather than reusing existing one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org