You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/20 11:32:49 UTC
[GitHub] [incubator-mxnet] ciyongch opened a new pull request #18109: Update Apache License for mshadow
ciyongch opened a new pull request #18109:
URL: https://github.com/apache/incubator-mxnet/pull/18109
## Description ##
Update Apache License for mshadow as described in https://github.com/apache/incubator-mxnet/issues/17329.
@TaoLv @pengzhao-intel @szha
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on issue #18109: Update Apache License for mshadow
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #18109:
URL: https://github.com/apache/incubator-mxnet/pull/18109#issuecomment-617297663
@mxnet-bot run ci [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on issue #18109: Update Apache License for mshadow
Posted by GitBox <gi...@apache.org>.
ciyongch commented on issue #18109:
URL: https://github.com/apache/incubator-mxnet/pull/18109#issuecomment-616497300
Ping @mjwall as well.
I will backport this PR to v1.x and v1.7.x branch later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on issue #18109: Update Apache License for mshadow
Posted by GitBox <gi...@apache.org>.
ciyongch commented on issue #18109:
URL: https://github.com/apache/incubator-mxnet/pull/18109#issuecomment-616521354
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18109: Update Apache License for mshadow
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18109:
URL: https://github.com/apache/incubator-mxnet/pull/18109#issuecomment-617297737
Jenkins CI successfully triggered : [unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18109: Update Apache License for mshadow
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18109:
URL: https://github.com/apache/incubator-mxnet/pull/18109#issuecomment-617483391
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on issue #18109: Update Apache License for mshadow
Posted by GitBox <gi...@apache.org>.
ciyongch commented on issue #18109:
URL: https://github.com/apache/incubator-mxnet/pull/18109#issuecomment-617524635
@TaoLv @pengzhao-intel @nswamy @szha Please help to take a review, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18109: Update Apache License for mshadow
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18109:
URL: https://github.com/apache/incubator-mxnet/pull/18109#issuecomment-616521436
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] pengzhao-intel commented on issue #18109: Update Apache License for mshadow
Posted by GitBox <gi...@apache.org>.
pengzhao-intel commented on issue #18109:
URL: https://github.com/apache/incubator-mxnet/pull/18109#issuecomment-617548126
Looks and merging now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18109: Update Apache License for mshadow
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18109:
URL: https://github.com/apache/incubator-mxnet/pull/18109#issuecomment-616493029
Hey @ciyongch , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-cpu, sanity, clang, unix-gpu, website, edge, miscellaneous, windows-gpu, windows-cpu, centos-gpu, unix-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on issue #18109: Update Apache License for mshadow
Posted by GitBox <gi...@apache.org>.
leezu commented on issue #18109:
URL: https://github.com/apache/incubator-mxnet/pull/18109#issuecomment-616839644
Please update the RAT license checker to enforce license in the 3rdparty/mshadow folder
Ie need to fix this line
https://github.com/apache/incubator-mxnet/blob/6198d1d7e10ba58ccc64ab7701d0c528b64bd58e/tests/nightly/apache_rat_license_check/rat-excludes#L34
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on issue #18109: Update Apache License for mshadow
Posted by GitBox <gi...@apache.org>.
ciyongch commented on issue #18109:
URL: https://github.com/apache/incubator-mxnet/pull/18109#issuecomment-617483367
@mxnet-bot run ci [unix-gpu ]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] ciyongch commented on issue #18109: Update Apache License for mshadow
Posted by GitBox <gi...@apache.org>.
ciyongch commented on issue #18109:
URL: https://github.com/apache/incubator-mxnet/pull/18109#issuecomment-617172366
> Thanks @ciyongch ! Let's have a mechanism to ensure the mshadow folder stays compliant (ie. disable the exclusion in rat?)
@leezu Thanks for point it out, I've updated the `rat-excludes` to enable check for `mshadow`, and keep the rest of folders under `3rdparty` unchanged. Not sure if there's any other elegant way to handle this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org