You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/08 11:39:02 UTC
[GitHub] [superset] geido opened a new pull request, #19614: chore: Remove wrong usage of font-size in ExploreViewContainer
geido opened a new pull request, #19614:
URL: https://github.com/apache/superset/pull/19614
### SUMMARY
It removes an unnecessary font-size and fixes a className to match the right layout as detailed in https://github.com/apache/superset/discussions/19099
### BEFORE
<img width="796" alt="Screen Shot 2022-04-08 at 14 38 43" src="https://user-images.githubusercontent.com/60598000/162428437-50a45d7c-58a3-4537-9204-fb3e2c708be9.png">
### AFTER
<img width="822" alt="Screen Shot 2022-04-08 at 14 37 00" src="https://user-images.githubusercontent.com/60598000/162428266-7aae0c0f-b74a-4fcd-84e5-75bdf20059b5.png">
### TESTING INSTRUCTIONS
1. Open Explore
2. Make sure the title of the left side panel has the right font-size and color
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido merged pull request #19614: chore: Remove wrong usage of font-size in ExploreViewContainer
Posted by GitBox <gi...@apache.org>.
geido merged PR #19614:
URL: https://github.com/apache/superset/pull/19614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #19614: chore: Remove wrong usage of font-size in ExploreViewContainer
Posted by GitBox <gi...@apache.org>.
geido commented on PR #19614:
URL: https://github.com/apache/superset/pull/19614#issuecomment-1095105614
Just had a discussion with Kasia. All of those headers should be 12px and I am going to apply the changes to this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #19614: chore: Remove wrong usage of font-size in ExploreViewContainer
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on PR #19614:
URL: https://github.com/apache/superset/pull/19614#issuecomment-1095160693
Waaaaaay better! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #19614: chore: Remove wrong usage of font-size in ExploreViewContainer
Posted by GitBox <gi...@apache.org>.
geido commented on PR #19614:
URL: https://github.com/apache/superset/pull/19614#issuecomment-1095116283
@michael-s-molina here is how it looks now
<img width="917" alt="Screen Shot 2022-04-11 at 17 21 53" src="https://user-images.githubusercontent.com/60598000/162760381-bea599f4-cddb-4776-8ed3-0cb66ee8a737.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19614: chore: Remove wrong usage of font-size in ExploreViewContainer
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19614:
URL: https://github.com/apache/superset/pull/19614#issuecomment-1092797280
# [Codecov](https://codecov.io/gh/apache/superset/pull/19614?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19614](https://codecov.io/gh/apache/superset/pull/19614?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (86a2a07) into [master](https://codecov.io/gh/apache/superset/commit/83c3779a6c3f7cc371dd8b8bf70519ec473954db?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (83c3779) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #19614 +/- ##
==========================================
+ Coverage 66.63% 66.66% +0.02%
==========================================
Files 1680 1681 +1
Lines 64292 64309 +17
Branches 6564 6565 +1
==========================================
+ Hits 42839 42869 +30
+ Misses 19751 19747 -4
+ Partials 1702 1693 -9
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.52% <ø> (+0.06%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19614?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../explore/components/ExploreViewContainer/index.jsx](https://codecov.io/gh/apache/superset/pull/19614/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci9pbmRleC5qc3g=) | `54.39% <ø> (ø)` | |
| [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/superset/pull/19614/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | `52.08% <0.00%> (-0.30%)` | :arrow_down: |
| [...ntend/packages/superset-ui-core/src/color/utils.ts](https://codecov.io/gh/apache/superset/pull/19614/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29sb3IvdXRpbHMudHM=) | `100.00% <0.00%> (ø)` | |
| [...c/views/CRUD/data/database/DatabaseModal/index.tsx](https://codecov.io/gh/apache/superset/pull/19614/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `32.79% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-partition/src/Partition.js](https://codecov.io/gh/apache/superset/pull/19614/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcnRpdGlvbi9zcmMvUGFydGl0aW9uLmpz) | `0.00% <0.00%> (ø)` | |
| [...ins/legacy-plugin-chart-sankey/src/ReactSankey.jsx](https://codecov.io/gh/apache/superset/pull/19614/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXNhbmtleS9zcmMvUmVhY3RTYW5rZXkuanN4) | `0.00% <0.00%> (ø)` | |
| [...s/legacy-plugin-chart-horizon/src/HorizonChart.jsx](https://codecov.io/gh/apache/superset/pull/19614/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LWhvcml6b24vc3JjL0hvcml6b25DaGFydC5qc3g=) | `0.00% <0.00%> (ø)` | |
| [...acy-plugin-chart-paired-t-test/src/PairedTTest.jsx](https://codecov.io/gh/apache/superset/pull/19614/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhaXJlZC10LXRlc3Qvc3JjL1BhaXJlZFRUZXN0LmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...rt-parallel-coordinates/src/ParallelCoordinates.js](https://codecov.io/gh/apache/superset/pull/19614/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcmFsbGVsLWNvb3JkaW5hdGVzL3NyYy9QYXJhbGxlbENvb3JkaW5hdGVzLmpz) | `0.00% <0.00%> (ø)` | |
| [...allel-coordinates/src/ReactParallelCoordinates.jsx](https://codecov.io/gh/apache/superset/pull/19614/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcmFsbGVsLWNvb3JkaW5hdGVzL3NyYy9SZWFjdFBhcmFsbGVsQ29vcmRpbmF0ZXMuanN4) | `0.00% <0.00%> (ø)` | |
| ... and [7 more](https://codecov.io/gh/apache/superset/pull/19614/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19614?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19614?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [83c3779...86a2a07](https://codecov.io/gh/apache/superset/pull/19614?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #19614: chore: Remove wrong usage of font-size in ExploreViewContainer
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on PR #19614:
URL: https://github.com/apache/superset/pull/19614#issuecomment-1095077830
I'm not sure if we can make this change without changing the other headers together. The Dataset header looked disproportional when testing the application. It looks like those commit all or roll back all kinds of PR. What do you think @kasiazjc?
<img width="285" alt="Screen Shot 2022-04-11 at 10 42 46 AM" src="https://user-images.githubusercontent.com/70410625/162752760-4f582ee0-6a94-4b2d-b60b-29f82e2f60bf.png">
<img width="352" alt="Screen Shot 2022-04-11 at 10 43 45 AM" src="https://user-images.githubusercontent.com/70410625/162752891-07a0de29-aa31-4b63-bc33-ccc0e09b494f.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org