[GitHub] [phoenix] christinefeng commented on a change in pull request #676: PHOENIX-5636: Improve the error message when client connects to server with higher major version

[GitBox <gi...@apache.org>]

christinefeng commented on a change in pull request #676: PHOENIX-5636: Improve the error message when client connects to server with higher major version
URL: https://github.com/apache/phoenix/pull/676#discussion_r385415180
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
 ##########
 @@ -1570,6 +1575,15 @@ public GetVersionResponse call(MetaDataService instance)
                     systemCatalogTimestamp = systemCatalogTimestamp < versionResponse.getSystemCatalogTimestamp() ?
                       systemCatalogTimestamp: versionResponse.getSystemCatalogTimestamp();
                 }
+
+                if (compatibility.getErrorCode() != 0) {
+                    if (compatibility.getErrorCode() == SQLExceptionCode.OUTDATED_JARS.getErrorCode()) {
+                        errorMessage.setLength(errorMessage.length()-1);
 
 Review comment:
   The setLength(length-1) gets rid of a trailing semicolon if there are multiple outdated jars error messages strung together (for loop at line 1540) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services