You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2020/04/01 00:19:35 UTC

[kudu-CR] [ranger] authorize list tables should never throw NotAuthorized

Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15609 )

Change subject: [ranger] authorize list tables should never throw NotAuthorized
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15609/2/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:

http://gerrit.cloudera.org:8080/#/c/15609/2/src/kudu/ranger/ranger_client.cc@383
PS2, Line 383:  unordered_set<string> allowed_tables;
             :   for (auto i =
> Sorry I wasn't clearer, by "empty list checks" I meant all the checks we ha
Ah, I see. Agree, I can do a follow up patch for it.



-- 
To view, visit http://gerrit.cloudera.org:8080/15609
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d1df45a82acc70000783f0cbcce4d3c81840176
Gerrit-Change-Number: 15609
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 01 Apr 2020 00:19:35 +0000
Gerrit-HasComments: Yes