You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/22 05:55:31 UTC

[GitHub] [pulsar] Pomelongan opened a new pull request, #17792: fix comments for exposeManagedLedgerMetricsInPrometheus field

Pomelongan opened a new pull request, #17792:
URL: https://github.com/apache/pulsar/pull/17792

   ### Motivation
   The default value of the exposeManagedLedgerMetricsInPrometheus field is true, but the comment says that the default value is false.
   ### Modifications
   Correct the comment of exposeManagedLedgerMetricsInPrometheus field.
   
   ### Verifying this change
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   - [x] `doc-not-needed` 
   (Please explain why)
   
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Jason918 merged pull request #17792: [fix][doc]fix comments for exposeManagedLedgerMetricsInPrometheus field

Posted by GitBox <gi...@apache.org>.
Jason918 merged PR #17792:
URL: https://github.com/apache/pulsar/pull/17792


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] AnonHxy commented on pull request #17792: [fix][doc]fix comments for exposeManagedLedgerMetricsInPrometheus field

Posted by GitBox <gi...@apache.org>.
AnonHxy commented on PR #17792:
URL: https://github.com/apache/pulsar/pull/17792#issuecomment-1254959181

   /pulsarbot ready-to-test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] HQebupt commented on pull request #17792: fix comments for exposeManagedLedgerMetricsInPrometheus field

Posted by GitBox <gi...@apache.org>.
HQebupt commented on PR #17792:
URL: https://github.com/apache/pulsar/pull/17792#issuecomment-1254566896

   The title`[fix][doc]fix comments for exposeManagedLedgerMetricsInPrometheus field ` is better.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Pomelongan commented on pull request #17792: [fix][doc]fix comments for exposeManagedLedgerMetricsInPrometheus field

Posted by GitBox <gi...@apache.org>.
Pomelongan commented on PR #17792:
URL: https://github.com/apache/pulsar/pull/17792#issuecomment-1256977453

   > The title`[fix][doc]fix comments for exposeManagedLedgerMetricsInPrometheus field ` is better.
   PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Pomelongan commented on pull request #17792: [fix][doc]fix comments for exposeManagedLedgerMetricsInPrometheus field

Posted by GitBox <gi...@apache.org>.
Pomelongan commented on PR #17792:
URL: https://github.com/apache/pulsar/pull/17792#issuecomment-1256980735

   @Jason918  PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org