You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@phoenix.apache.org by GitBox <gi...@apache.org> on 2022/08/06 16:01:57 UTC

[GitHub] [phoenix-omid] gjacoby126 commented on a diff in pull request #108: OMID-224 Switch default logging backend to log4j2

gjacoby126 commented on code in PR #108:
URL: https://github.com/apache/phoenix-omid/pull/108#discussion_r939545022


##########
hbase-commit-table/pom.xml:
##########
@@ -112,13 +117,32 @@
             <artifactId>curator-test</artifactId>
             <scope>test</scope>
         </dependency>
+
+
+        <!-- log4j2 test dependencies -->
+
+        <dependency>
+            <groupId>org.apache.logging.log4j</groupId>
+            <artifactId>log4j-api</artifactId>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.logging.log4j</groupId>
+            <artifactId>log4j-core</artifactId>
+            <scope>test</scope>
+        </dependency>
         <dependency>
-            <groupId>org.apache.zookeeper</groupId>
-            <artifactId>zookeeper</artifactId>

Review Comment:
   Is the zookeeper reference not needed anymore?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org