[GitHub] [beam] liferoad commented on a diff in pull request #26923: fix output_handler

["liferoad (via GitHub)" <gi...@apache.org>]

liferoad commented on code in PR #26923:
URL: https://github.com/apache/beam/pull/26923#discussion_r1214437603


##########
sdks/python/apache_beam/transforms/util_test.py:
##########
@@ -908,7 +908,7 @@ def test_in_global_window_with_text_file(self):
     with tempfile.NamedTemporaryFile(suffix=".json") as f:
       with open(f.name, "w") as fh:
         json.dump(GroupIntoBatchesTest._create_test_data(), fh)
-      with self.assertRaises(RuntimeError):
+      with self.assertRaises((RuntimeError, AttributeError)):

Review Comment:
   I do not think we should waste time on this given we will not improve DirectRunner. This failure now is directly linked to GroupIntoBatches, which is also experimental.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org