You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/02/11 21:40:35 UTC

[GitHub] [incubator-mxnet] apeforest edited a comment on issue #16735: Use single-bit for mask in dropout operator

apeforest edited a comment on issue #16735: Use single-bit for mask in dropout operator
URL: https://github.com/apache/incubator-mxnet/pull/16735#issuecomment-584766500
 
 
   @TaoLv Thanks for your review and suggestion. 
   
   Using blocking does help. This is the new runtime using python timer:
   
   ```
   [{'Dropout': [{'avg_time_Dropout': 2.9556092573329806, 'p50_time_Dropout': 2.9536145739257336, 'p90_time_Dropout': 2.9735330026596785, 'p99_time_Dropout': 3.0410749791190033, 'inputs': {'data': (1024, 1024)}}]}]
   ```
   
   I also updated the runtime using mxnet profiler w/ my performance script in the PR description section. Please refer above.
   
   I am not in favor of adding an option. It exposes internal implementation (e.g. using bit mask or not) to users and is also counterintuitive (why not use bit-mask). If sacrificing performance (to some extent) can help improve usability, I think we need to consider the trade off.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services