[GitHub] [flink] 1u0 edited a comment on issue #8199: [FLINK-11955] Modify build to move filesystems from lib to plugins folder

[GitBox <gi...@apache.org>]

1u0 edited a comment on issue #8199: [FLINK-11955] Modify build to move filesystems from lib to plugins folder
URL: https://github.com/apache/flink/pull/8199#issuecomment-500820126
 
 
   @yanghua, it's possible that this PR is not needed (at the moment).
   
   Currently, the work done in FLINK-12143 is neutral about Flink distribution dir layout.
   But the concerns raised by @zentol are still valid, imo.
   Further, I just share my own opinion that similar to Chesnay's.
   
   **Note:** the implementation in plugin manager scans jars with plugins by `plugins/*/*.jar` file path match.
   
   If the intended target dir in this PR should be `plugins` instead of `plugin`, then such distribution would automatically enable all moved file system plugins by default (already mentioned by Chesnay: " .. having them on the classpath by default"). This may be not desirable for some Flink users. Or at least, it may be surprising for them.
   
   Otherwise, if this PR just relocates (but not enables by default) the optional file system jars under new path, then it may be worth to consider some other subdir (keeping the jars under `opt/` directory). But this change doesn't bring much value for Flink users, imo. It would also require users to change their Flink start up setups.
   
   _Update:_ I think there is a value in relocating the fs plugins done together with un-shading them ([FLINK-11956](https://issues.apache.org/jira/browse/FLINK-11956)). Because in that case, the jars would be not backwards compatible and should be loaded only via plugin manager. This way we can "force" Flink users to properly adjust their Flink setups. But in that case, I'd propose to consider keeping them under some `opt/` subdir.
   
   Unfortunately, the scope and goals of FLINK-11955 are not clear. Maybe you (@yanghua), or @pnowojski, or @StefanRRichter could clarify if this effort is still needed? And if it was intended to enable file system  plugins by default or just relocate the jars?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services