[I] Follow ups on RLI and SI MDT record generation fixes [hudi]

["hudi-bot (via GitHub)" <gi...@apache.org>]

hudi-bot opened a new issue, #17315:
URL: https://github.com/apache/hudi/issues/17315

   we fixed RLI and SI record generation recently for 1.x release [https://github.com/apache/hudi/pull/12321] 
   
    
   
   Few optimizations have been punted. filing this for tracking purpose. 
    * Enums for writesFileIdEncoding
    * Avoid code duplication across RLI record generation and fetching deletedorUpdated recordKeys for SI 
   
   ## JIRA info
   
   - Link: https://issues.apache.org/jira/browse/HUDI-8597
   - Type: Sub-task
   - Parent: https://issues.apache.org/jira/browse/HUDI-9176
   - Fix version(s):
     - 1.1.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Follow ups on RLI and SI MDT record generation fixes [hudi]

["rangareddy (via GitHub)" <gi...@apache.org>]

rangareddy commented on issue #17315:
URL: https://github.com/apache/hudi/issues/17315#issuecomment-5365821906

   This issue was reviewed as part of the JIRA-migrated backlog triage (HUDI-8597).
   
   **Findings: still open; both punted items appear outstanding.**
   
   This is a self-describing follow-up ticket. The underlying fix landed as PR #12321 (`[HUDI-8564] Removing WriteStatus references in Hoodie Metadata writer flow`, merged 2024-11-28) and two optimisations were deferred:
   
   1. enums for `writesFileIdEncoding`
   2. removing the code duplication between RLI record generation and the deleted-or-updated record-key fetch for secondary index
   
   Neither appears to have landed.
   
   One important caveat for whoever picks this up: the metadata write path was restructured after this was filed. The indexer abstraction (#18348, #18372) moved RLI and secondary-index record generation into dedicated `RecordIndexer` / `SecondaryIndexer` classes under `hudi-client-common`. The duplication in item 2 should be re-located against that structure - it may have been resolved incidentally by the refactor, or it may have been carried across into both indexers. Checking which is the first step.
   
   Keeping this open.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org