You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by nssalian <gi...@git.apache.org> on 2016/10/26 02:49:09 UTC
[GitHub] incubator-beam pull request #1191: [BEAM-651]: Consider making TypedPValue.s...
GitHub user nssalian opened a pull request:
https://github.com/apache/incubator-beam/pull/1191
[BEAM-651]: Consider making TypedPValue.setTypeDescriptorInternal no longer Internal
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
On the PR: Refactored the project to modify the name of setTypeDescriptorInternal to setTypeDescriptor.
Ran a mvn clean install to SUCCESS and a local TRAVIS build went through as well.
@kennknowles , do you have some to help review?
Thank you.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nssalian/incubator-beam BEAM-651-branch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1191.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1191
----
commit b5983ed63ff285fdf368f4b9c07a05236e375167
Author: Neelesh Srinivas Salian <ns...@cloudera.com>
Date: 2016-10-26T02:29:09Z
BEAM-651: Renaming setTypeDescriptorInternal to setTypeDescriptor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #1191: [BEAM-651]: Consider making TypedPValue.s...
Posted by nssalian <gi...@git.apache.org>.
Github user nssalian closed the pull request at:
https://github.com/apache/incubator-beam/pull/1191
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---