[jira] [Work logged] (TS-4870) Storage can be marked offline multiple times which breaks related metrics

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/TS-4870?focusedWorklogId=29201&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29201 ]

ASF GitHub Bot logged work on TS-4870:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Sep/16 20:50
            Start Date: 15/Sep/16 20:50
    Worklog Time Spent: 10m 
      Work Description: GitHub user gtenev opened a pull request:

    https://github.com/apache/trafficserver/pull/1028

    TS-4870 Avoid marking storage offline multiple times

    Currently storage can be marked offline multiple times which breaks related metrics.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gtenev/trafficserver TS-4870

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/1028.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1028
    
----
commit b1389f36936bbfcee6ee645e9954eeae92d4e7ed
Author: Gancho Tenev <gt...@gmail.com>
Date:   2016-09-15T13:44:44Z

    TS-4870 Avoid marking storage offline multiple times
    
    Currently storage can be marked offline multiple times which breaks related metrics.

----


Issue Time Tracking
-------------------

            Worklog Id:     (was: 29201)
            Time Spent: 10m
    Remaining Estimate: 0h

> Storage can be marked offline multiple times which breaks related metrics
> -------------------------------------------------------------------------
>
>                 Key: TS-4870
>                 URL: https://issues.apache.org/jira/browse/TS-4870
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Cache, Metrics
>            Reporter: Gancho Tenev
>            Assignee: Gancho Tenev
>             Fix For: 7.0.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Let us say traffic server is running with 2 disks
> {code}
> $ cat etc/trafficserver/storage.config
> /dev/sdb
> /dev/sdc
> $ sudo fdisk -l|grep 'Disk /dev/sd[b|c]'
> Disk /dev/sdb: 134 MB, 134217728 bytes
> Disk /dev/sdc: 134 MB, 134217728 bytes
> {code}
> Let us see what happens when we mark the same disk 3 times in a raw ({{/dev/sdb}}) and check the {{proxy.node.cache.bytes_total}}.
> {code}
> # Initial cache size (when using both disks).
> $ ./bin/traffic_ctl metric get proxy.node.cache.bytes_total
> proxy.node.cache.bytes_total 268025856
> # Take 1st disk offline. Cache size changes as expected.
> $ sudo ./bin/traffic_ctl storage offline /dev/sdb
> $ ./bin/traffic_ctl metric get proxy.node.cache.bytes_total
> proxy.node.cache.bytes_total 134012928
> # Take same disk offline again. Not good!
> $ sudo ./bin/traffic_ctl storage offline /dev/sdb
> $ ./bin/traffic_ctl metric get proxy.node.cache.bytes_total
> proxy.node.cache.bytes_total 0
> # Take same disk offline again. Negative value.
> $ sudo ./bin/traffic_ctl storage offline /dev/sdb
> $ ./bin/traffic_ctl metric get proxy.node.cache.bytes_total
> proxy.node.cache.bytes_total -134012928
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)