You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/07/27 11:27:52 UTC

[GitHub] [hudi] fengjian428 commented on a diff in pull request #6144: [HUDI-4424] add new compactoin trigger stratgy: NUM_COMMITS_AFTER_REQ…

fengjian428 commented on code in PR #6144:
URL: https://github.com/apache/hudi/pull/6144#discussion_r930946960


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/ScheduleCompactionActionExecutor.java:
##########
@@ -140,6 +140,17 @@ private Option<Pair<Integer, String>> getLatestDeltaCommitInfo() {
     return Option.empty();
   }
 
+  private Option<Pair<Integer, String>> getLatestDeltaCommitInfoSinceCompactionRequest() {
+    Option<Pair<HoodieTimeline, HoodieInstant>> deltaCommitsInfo =

Review Comment:
   I think using deltaCommitsInfo here should be ok since the left value is delta Commits after the right value, WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org