[jira] [Commented] (OPENNLP-1421) Improve tests in opennlp.tools.formats package

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17650863#comment-17650863 ] 

ASF GitHub Bot commented on OPENNLP-1421:
-----------------------------------------

mawiesne opened a new pull request, #466:
URL: https://github.com/apache/opennlp/pull/466

   Change
   -
   - introduces common base test classes `Abstract...Test` to reduce code duplication for resource handling
   - extracts (test) resource loading into separate methods
   - adds further assertions for existing tests where useful
   - adds final modifier where applicable
   - adjusts `TokenSample` to implement `opennlp.tools.commons.Sample`
   - fixes some typos
   
   Tasks
   -
   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
   - [x] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
   - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.
   




> Improve tests in opennlp.tools.formats package
> ----------------------------------------------
>
>                 Key: OPENNLP-1421
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1421
>             Project: OpenNLP
>          Issue Type: Improvement
>          Components: Build, Packaging and Test, Formats
>    Affects Versions: 2.1.0
>            Reporter: Martin Wiesner
>            Assignee: Martin Wiesner
>            Priority: Minor
>             Fix For: 2.1.1
>
>
> The unit tests for the _opennlp.tools.formats_ package can be optimized towards _less_ code duplication. For the current test classes, this is observed for reading or loading (file-based) resources required to conduct the actual testing.
> Aims:
>  * Reduce code duplication
>  * Extract common ways of finding/scanning/reading resource files
>  * Optimize tests towards clarity



--
This message was sent by Atlassian Jira
(v8.20.10#820010)