You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/12/19 21:28:00 UTC

[jira] [Commented] (AIRFLOW-3546) Typo in jobs.py logs

    [ https://issues.apache.org/jira/browse/AIRFLOW-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725352#comment-16725352 ] 

ASF GitHub Bot commented on AIRFLOW-3546:
-----------------------------------------

stankud opened a new pull request #4346: [AIRFLOW-3546] Fix typos in jobs.py logs
URL: https://github.com/apache/incubator-airflow/pull/4346
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-3546) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3546
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [x ] Here are some details about my PR, including screenshots of any UI changes:
   Scheduler logs the following:
   ```
   ...INFO - Setting the follow tasks to queued state:
   ```
   this PR changes `follow` to `following`
   
   ### Tests
   
   - [ x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   This is a trivial change which doesn't need tests
   
   ### Commits
   
   - [x ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ x] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [x ] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Typo in jobs.py logs
> --------------------
>
>                 Key: AIRFLOW-3546
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3546
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: scheduler
>            Reporter: Stan Kudrow
>            Assignee: Stan Kudrow
>            Priority: Trivial
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)