You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/08/26 01:55:55 UTC

[GitHub] [druid] maytasm commented on pull request #10307: Add support for all partitioing schemes for auto compaction

maytasm commented on pull request #10307:
URL: https://github.com/apache/druid/pull/10307#issuecomment-680413632


   > @maytasm thanks for the review.
   > 
   > > LGTM - Would be great if you can add Integration Tests. There are already existing auto compaction integration tests so it should not be too hard to add for this PR.
   > 
   > That's a good idea. Do you mind if I add them in a follow-up PR with doc changes?
   
   I think it's fine to add in a follow up PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org