You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@httpd.apache.org by Sander Striker <st...@apache.org> on 2002/04/16 01:46:38 UTC

[PATCH] leader, uninitialized variable

Hi,

I'm seeing:

leader.c:942: warning: `rv' might be used uninitialized in this function

Don't know if this is the correct error code to return, but it removes
the warning.

Sander


Index: server/mpm/experimental/leader/leader.c
===================================================================
RCS file: /home/cvs/httpd-2.0/server/mpm/experimental/leader/leader.c,v
retrieving revision 1.7
diff -u -r1.7 leader.c
--- server/mpm/experimental/leader/leader.c     15 Apr 2002 23:11:51 -0000      1.7
+++ server/mpm/experimental/leader/leader.c     15 Apr 2002 23:37:22 -0000
@@ -947,7 +947,7 @@

     idle_worker_stack = worker_stack_create(pchild, ap_threads_per_child);
     if (idle_worker_stack == NULL) {
-        ap_log_error(APLOG_MARK, APLOG_ALERT, rv, ap_server_conf,
+        ap_log_error(APLOG_MARK, APLOG_ALERT, APR_EGENERAL, ap_server_conf,
                      "worker_stack_create() failed");
         clean_child_exit(APEXIT_CHILDFATAL);
     }

Re: [PATCH] leader, uninitialized variable

Posted by Brian Pane <bp...@pacbell.net>.

Sander Striker wrote:

>Hi,
>
>I'm seeing:
>
>leader.c:942: warning: `rv' might be used uninitialized in this function
>

Thanks, I just committed a fix.

--Brian