[jira] [Comment Edited] (SENTRY-2143) Table renames should synchronize with Sentry

["Alexander Kolbasov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373977#comment-16373977 ] 

Alexander Kolbasov edited comment on SENTRY-2143 at 2/23/18 6:24 AM:
---------------------------------------------------------------------

[~LinaAtAustin] I'm a bit confused here. Please clarify a few things.

{quote}
1) SentrySyncHMSNotificationsPostEventListener.syncNotificationEvents does not do anything for alter table event because HiveMetaStore does not set the notification ID in the event's parameter
{quote}

The code that you quote was done by [~spena] - Sergio - what do you think about this?

{quote}
2) Notification ID is set for create database, create table etc, but not set for alter table event.
{quote}
 Why do you think that it doesn't?

In the snippet above isn't {{MetaStoreListenerNotifier.notifyEvent()}} doing exactly that - creating an event and storing event ID there?


was (Author: akolb):
[~LinaAtAustin] I'm a bit confused here. Please clarify a few things.

{quote}
1) SentrySyncHMSNotificationsPostEventListener.syncNotificationEvents does not do anything for alter table event because HiveMetaStore does not set the notification ID in the event's parameter
{quote}

The code that you quote was done by [~spena] - Sergio - what do you think about this?

{quote}
2) Notification ID is set for create database, create table etc, but not set for alter table event.
{quote}
 Why do you think that it doesn't?

In the snippet above isn't {{MetaStoreListenerNotifier.notifyEvent()}} 

> Table renames should synchronize with Sentry
> --------------------------------------------
>
>                 Key: SENTRY-2143
>                 URL: https://issues.apache.org/jira/browse/SENTRY-2143
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: 2.1.0
>            Reporter: Alexander Kolbasov
>            Assignee: Na Li
>            Priority: Major
>         Attachments: SENTRY-2143.001.patch, SENTRY-2143.002.patch, SENTRY-2143.003.patch, SENTRY-2143.004.patch
>
>
> Currently table renames are not synchronized from Hive (while table creates/drops are). This creates a problem since the renamed table doesn't have correct privileges for a bit until it is processed by Sentry. So perfectly valid scripts that rename tables and expect the rename table to retain the privileges are going to fail.
> The fix is to update {{SentrySyncHMSNotificationsPostEventListener}} to synchronize table renames as well.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)