[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #12464: ARROW-15665: [C++] Add error handling option to StrptimeOptions

[GitBox <gi...@apache.org>]

jorisvandenbossche commented on a change in pull request #12464:
URL: https://github.com/apache/arrow/pull/12464#discussion_r831432830



##########
File path: python/pyarrow/_compute.pyx
##########
@@ -1458,10 +1459,12 @@ class StrptimeOptions(_StrptimeOptions):
     unit : str
         Timestamp unit of the output.
         Accepted values are "s", "ms", "us", "ns".
+    error_is_null : boolean, default False
+        Return null on parsing errors if true or raise if false.
     """
 
-    def __init__(self, format, unit):
-        self._set_options(format, unit)
+    def __init__(self, format, unit, error_is_null=True):

Review comment:
       This should be False for the default? 
   
   Can you also add a test for this default? (a test that checks an error is raised for the default options without explicitly passing `error_is_null`)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org