[jira] [Commented] (TEZ-386) Abstract ParallelStart into its own class and move it out of DAGAppMaster

["Bikas Saha (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787769#comment-13787769 ] 

Bikas Saha commented on TEZ-386:
--------------------------------

Thanks for the patch. Looks good overall.

The intention of this is similar for TEZ-387 - to make the class unit testable by decoupling it from the other code. The patch does decouple the code. To finish off, it would be great if a simple unit test for the new class could be added that checks that services are being started in parallel.

Once this class is properly tested, we can try to contribute it back to the Apache YARN code base. That would be an even better contribution.

> Abstract ParallelStart into its own class and move it out of DAGAppMaster
> -------------------------------------------------------------------------
>
>                 Key: TEZ-386
>                 URL: https://issues.apache.org/jira/browse/TEZ-386
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Bikas Saha
>            Assignee: Raghavendra Nandagopal
>              Labels: newbie
>         Attachments: TEZ-386.patch
>
>
> The parallel start logic code is contained inside DAGAppMaster. We should move it out into its own class as this will help unit testing it.



--
This message was sent by Atlassian JIRA
(v6.1#6144)