You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Li Pi (JIRA)" <ji...@apache.org> on 2011/08/31 08:13:10 UTC
[jira] [Created] (HBASE-4310) SlabCache metrics bugfix.
SlabCache metrics bugfix.
-------------------------
Key: HBASE-4310
URL: https://issues.apache.org/jira/browse/HBASE-4310
Project: HBase
Issue Type: Sub-task
Reporter: Li Pi
Assignee: Li Pi
Priority: Minor
Attachments: metrics.txt
math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Li Pi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi updated HBASE-4310:
-------------------------
Description: math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space. Also added second log for those things that are successfully cached. (was: math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space.)
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt, metrics.txt, metrics.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space. Also added second log for those things that are successfully cached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Li Pi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi updated HBASE-4310:
-------------------------
Attachment: metricsv2.txt
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt, metrics.txt, metrics.txt, metricsv2.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space. Also added second log for those things that are successfully cached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095099#comment-13095099 ]
Ted Yu commented on HBASE-4310:
-------------------------------
Minor comment:
{code}
+ + StringUtils.humanReadableInt(this.heapSize()) + " bytes." + ", "
+ + "churnTime=" + this.timeSinceLastAccess.get());
{code}
churnTime should have unit. Since the value would be big in nanoseconds, there should be some normalization.
Otherwise, patch looks good.
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt, metrics.txt, metrics.txt, metricsv2.txt, metricsv2.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space. Also added second log for those things that are successfully cached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094398#comment-13094398 ]
Ted Yu commented on HBASE-4310:
-------------------------------
{code}
+ final SlabStats cachedSuccessfullyStats;
{code}
Shouldn't this field be called successfullyCachedStats ?
+1 overall.
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt, metrics.txt, metrics.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space. Also added second log for those things that are successfully cached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104949#comment-13104949 ]
Jonathan Gray commented on HBASE-4310:
--------------------------------------
Can someone explain the three commits on this JIRA? Is the final commit from a different JIRA? It has a different commit message name but is linked to this JIRA and there is nothing in CHANGES.txt and nothing here in the JIRA talking about the change?
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt, metrics.txt, metrics.txt, metricsv2.txt, metricsv2.txt, metricsv3.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space. Also added second log for those things that are successfully cached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104954#comment-13104954 ]
Jonathan Gray commented on HBASE-4310:
--------------------------------------
I see two separate lines for this JIRA in CHANGES as well. Is this was prompted some of those discussions about multiple commits on a JIRA? We should at least amend the CHANGES and commit message that it's a follow-up if nothing else.
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt, metrics.txt, metrics.txt, metricsv2.txt, metricsv2.txt, metricsv3.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space. Also added second log for those things that are successfully cached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095568#comment-13095568 ]
Ted Yu commented on HBASE-4310:
-------------------------------
+1 on patch version 3.
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt, metrics.txt, metrics.txt, metricsv2.txt, metricsv2.txt, metricsv3.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space. Also added second log for those things that are successfully cached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Li Pi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi reopened HBASE-4310:
--------------------------
Didn't fix the bug. Added test cases and a new patch.
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt, metrics.txt, metrics.txt, metricsv2.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space. Also added second log for those things that are successfully cached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094534#comment-13094534 ]
Ted Yu commented on HBASE-4310:
-------------------------------
Integrated to TRUNK after renaming.
Thanks for the patch Li.
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt, metrics.txt, metrics.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space. Also added second log for those things that are successfully cached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Li Pi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi updated HBASE-4310:
-------------------------
Status: Patch Available (was: Open)
fixed
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095034#comment-13095034 ]
Ted Yu commented on HBASE-4310:
-------------------------------
{code}
+ // the maximum size somebody will ever try to cache, then we multiply by 100
// so we have finer grained stats.
- private final int MULTIPLIER = 10;
- private final int NUMDIVISIONS = (int) (Math.log(Integer.MAX_VALUE) * MULTIPLIER);
+ final int MULTIPLIER = 10;
{code}
Is javadoc consistent with code ?
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt, metrics.txt, metrics.txt, metricsv2.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space. Also added second log for those things that are successfully cached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ted Yu updated HBASE-4310:
--------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt, metrics.txt, metrics.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space. Also added second log for those things that are successfully cached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Li Pi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi updated HBASE-4310:
-------------------------
Attachment: metricsv2.txt
also added a bit more logging
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt, metrics.txt, metrics.txt, metricsv2.txt, metricsv2.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space. Also added second log for those things that are successfully cached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094659#comment-13094659 ]
Hudson commented on HBASE-4310:
-------------------------------
Integrated in HBase-TRUNK #2165 (See [https://builds.apache.org/job/HBase-TRUNK/2165/])
HBASE-4310 SlabCache metrics bugfix (Li Pi)
tedyu :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt, metrics.txt, metrics.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space. Also added second log for those things that are successfully cached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Li Pi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi updated HBASE-4310:
-------------------------
Attachment: metrics.txt
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Li Pi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095048#comment-13095048 ]
Li Pi commented on HBASE-4310:
------------------------------
Nope. That should be 10. I changed it to 100, then realized that the divisions were too fine grained, and then changed it back again.
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt, metrics.txt, metrics.txt, metricsv2.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space. Also added second log for those things that are successfully cached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Li Pi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi updated HBASE-4310:
-------------------------
Attachment: metrics.txt
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt, metrics.txt, metrics.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Li Pi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi updated HBASE-4310:
-------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt, metrics.txt, metrics.txt, metricsv2.txt, metricsv2.txt, metricsv3.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space. Also added second log for those things that are successfully cached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Li Pi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi updated HBASE-4310:
-------------------------
Attachment: metricsv3.txt
log output looks prettier now. (used stringutils)
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt, metrics.txt, metrics.txt, metricsv2.txt, metricsv2.txt, metricsv3.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space. Also added second log for those things that are successfully cached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096140#comment-13096140 ]
Hudson commented on HBASE-4310:
-------------------------------
Integrated in HBase-TRUNK #2171 (See [https://builds.apache.org/job/HBase-TRUNK/2171/])
HBASE-4310 Fix check for lower and upper bounds
tedyu :
Files :
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/io/hfile/slab/TestSlabCache.java
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt, metrics.txt, metrics.txt, metricsv2.txt, metricsv2.txt, metricsv3.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space. Also added second log for those things that are successfully cached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095763#comment-13095763 ]
Ted Yu commented on HBASE-4310:
-------------------------------
Integrated to TRUNK.
Thanks for the patch Li.
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt, metrics.txt, metrics.txt, metricsv2.txt, metricsv2.txt, metricsv3.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space. Also added second log for those things that are successfully cached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Li Pi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Pi updated HBASE-4310:
-------------------------
Status: Patch Available (was: Reopened)
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt, metrics.txt, metrics.txt, metricsv2.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space. Also added second log for those things that are successfully cached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4310) SlabCache metrics bugfix.
Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104959#comment-13104959 ]
Ted Yu commented on HBASE-4310:
-------------------------------
I only see two notifications from HUDSON on this ticket.
The commit @ 2011-09-02 07:31:29 fixed the condition in an assertion:
{code}
- assert(test.getUpperBound(i) < test.getLowerBound(i + 1));
+ assertTrue("Upper for index " + i + " is " + test.getUpperBound(i) +
+ " lower " + test.getLowerBound(i + 1),
+ test.getUpperBound(i) <= test.getLowerBound(i + 1));
{code}
The addition of = came with the change in the way bounds are generated.
Without the above, TestSlabCache would fail.
I can remove the duplicate line in CHANGES.txt
> SlabCache metrics bugfix.
> -------------------------
>
> Key: HBASE-4310
> URL: https://issues.apache.org/jira/browse/HBASE-4310
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: metrics.txt, metrics.txt, metrics.txt, metricsv2.txt, metricsv2.txt, metricsv3.txt
>
>
> math error in metrics makes it display incorrect metrics. also no longer logs metrics of size 0 to save space. Also added second log for those things that are successfully cached.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira