You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/06/26 14:27:56 UTC

[GitHub] [iotdb] yuyuankang opened a new pull request, #6452: Image in English for IT document

yuyuankang opened a new pull request, #6452:
URL: https://github.com/apache/iotdb/pull/6452

   ## This pull request modifies the IT guidebook
   
   ### Instructions in some figures are translated into English (English document)
   
   ### Commands for starting IT are removed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] irvine0109 commented on a diff in pull request #6452: Image in English for IT document

Posted by GitBox <gi...@apache.org>.
irvine0109 commented on code in PR #6452:
URL: https://github.com/apache/iotdb/pull/6452#discussion_r907155183


##########
docs/UserGuide/Integration-Test/Integration-Test-refactoring-tutorial.md:
##########
@@ -220,44 +220,6 @@ public class IoTDBAlignedSeriesQueryIT {
 }
 ```
 
-### Commands for starting IT 

Review Comment:
   The commands part of running IT is already described at this link https://github.com/apache/iotdb/blob/master/integration-test/README.md, the counterpart of this page is stale and wrong.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] qiaojialin commented on a diff in pull request #6452: Image in English for IT document

Posted by GitBox <gi...@apache.org>.
qiaojialin commented on code in PR #6452:
URL: https://github.com/apache/iotdb/pull/6452#discussion_r907499457


##########
docs/UserGuide/Integration-Test/Integration-Test-refactoring-tutorial.md:
##########
@@ -220,44 +220,6 @@ public class IoTDBAlignedSeriesQueryIT {
 }
 ```
 
-### Commands for starting IT 

Review Comment:
   +1 for a link



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] irvine0109 commented on a diff in pull request #6452: Image in English for IT document

Posted by GitBox <gi...@apache.org>.
irvine0109 commented on code in PR #6452:
URL: https://github.com/apache/iotdb/pull/6452#discussion_r907155183


##########
docs/UserGuide/Integration-Test/Integration-Test-refactoring-tutorial.md:
##########
@@ -220,44 +220,6 @@ public class IoTDBAlignedSeriesQueryIT {
 }
 ```
 
-### Commands for starting IT 

Review Comment:
   The commands part is already described at this link https://github.com/apache/iotdb/blob/master/integration-test/README.md



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] irvine0109 commented on a diff in pull request #6452: Image in English for IT document

Posted by GitBox <gi...@apache.org>.
irvine0109 commented on code in PR #6452:
URL: https://github.com/apache/iotdb/pull/6452#discussion_r907161176


##########
docs/UserGuide/Integration-Test/Integration-Test-refactoring-tutorial.md:
##########
@@ -220,44 +220,6 @@ public class IoTDBAlignedSeriesQueryIT {
 }
 ```
 
-### Commands for starting IT 

Review Comment:
   Maybe we can put a link here. 
   What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] qiaojialin merged pull request #6452: Image in English for IT document

Posted by GitBox <gi...@apache.org>.
qiaojialin merged PR #6452:
URL: https://github.com/apache/iotdb/pull/6452


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] qiaojialin commented on a diff in pull request #6452: Image in English for IT document

Posted by GitBox <gi...@apache.org>.
qiaojialin commented on code in PR #6452:
URL: https://github.com/apache/iotdb/pull/6452#discussion_r906899229


##########
docs/UserGuide/Integration-Test/Integration-Test-refactoring-tutorial.md:
##########
@@ -220,44 +220,6 @@ public class IoTDBAlignedSeriesQueryIT {
 }
 ```
 
-### Commands for starting IT 

Review Comment:
   why remove this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org