You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/03 09:28:23 UTC

[GitHub] [inlong] kipshi commented on a diff in pull request #5338: [INLONG-5337][Manager] Add jsonSubType for Api Object

kipshi commented on code in PR #5338:
URL: https://github.com/apache/inlong/pull/5338#discussion_r936443940


##########
inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/cluster/ClusterInfo.java:
##########
@@ -37,6 +42,11 @@
 @AllArgsConstructor
 @ApiModel("Inlong cluster info")
 @JsonTypeInfo(use = JsonTypeInfo.Id.NAME, visible = true, property = "type")
+@JsonSubTypes({
+        @JsonSubTypes.Type(value = DataProxyClusterInfo.class, name = ClusterType.DATAPROXY),

Review Comment:
   JsonTypeDefine is used in child class, this is used in parent class, what do you mean?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org