You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by keval bhatt <kb...@apache.org> on 2017/06/29 05:27:50 UTC

Review Request 60528: UI : Search using entity and trait attributes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60528/
-----------------------------------------------------------

Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-1894
    https://issues.apache.org/jira/browse/ATLAS-1894


Repository: atlas


Description
-------

In basic search user can search based on attribute condition.


Diffs
-----

  3party-licenses/bootstrap-datepicker-LICENSE 3fd94fa 
  3party-licenses/bootstrap-daterangepicker-LICENSE PRE-CREATION 
  3party-licenses/jQuery-QueryBuilder-LICENSE PRE-CREATION 
  LICENSE 9722907 
  dashboardv2/gruntfile.js cf076b6 
  dashboardv2/package.json 8924f71 
  dashboardv2/public/css/scss/form.scss 3ee94f5 
  dashboardv2/public/css/scss/override.scss 2852f80 
  dashboardv2/public/css/scss/search.scss 8c3dbec 
  dashboardv2/public/index.html 5fff304 
  dashboardv2/public/js/collection/VSearchList.js 6a84943 
  dashboardv2/public/js/collection/VTagList.js 9304858 
  dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.js bb930fb 
  dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.min.css e9ec816 
  dashboardv2/public/js/main.js 3b40451 
  dashboardv2/public/js/models/VSearch.js 5c3df97 
  dashboardv2/public/js/models/VTag.js c875d5a 
  dashboardv2/public/js/router/Router.js f1250e7 
  dashboardv2/public/js/templates/search/QueryBuilder_tmpl.html PRE-CREATION 
  dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html a766cdf 
  dashboardv2/public/js/templates/search/SearchQuery_tmpl.html PRE-CREATION 
  dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 91f1a67 
  dashboardv2/public/js/templates/tag/AddTagAttributeView_tmpl.html a7f9146 
  dashboardv2/public/js/templates/tag/createTagLayoutView_tmpl.html 0491c78 
  dashboardv2/public/js/utils/Overrides.js b6fc17c 
  dashboardv2/public/js/utils/UrlLinks.js c692d8d 
  dashboardv2/public/js/utils/Utils.js 1d614a8 
  dashboardv2/public/js/views/business_catalog/SideNavLayoutView.js af18540 
  dashboardv2/public/js/views/entity/CreateEntityLayoutView.js 704062f 
  dashboardv2/public/js/views/search/QueryBuilderView.js PRE-CREATION 
  dashboardv2/public/js/views/search/SearchDetailLayoutView.js b22fae8 
  dashboardv2/public/js/views/search/SearchLayoutView.js 32b82d7 
  dashboardv2/public/js/views/search/SearchQueryView.js PRE-CREATION 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js 1198809 
  dashboardv2/public/js/views/tag/TagDetailLayoutView.js 3bb27c3 
  dashboardv2/public/js/views/tag/TagLayoutView.js a5b5665 


Diff: https://reviews.apache.org/r/60528/diff/1/


Testing
-------

Performed one round of sanity testing and UI is working fine


Thanks,

keval bhatt


Re: Review Request 60528: UI : Search using entity and trait attributes

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60528/#review179338
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On June 30, 2017, 8:22 a.m., keval bhatt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60528/
> -----------------------------------------------------------
> 
> (Updated June 30, 2017, 8:22 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-1894
>     https://issues.apache.org/jira/browse/ATLAS-1894
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> In basic search user can search based on attribute condition.
> 
> 
> Diffs
> -----
> 
>   3party-licenses/bootstrap-datepicker-LICENSE 3fd94fa 
>   3party-licenses/bootstrap-daterangepicker-LICENSE PRE-CREATION 
>   3party-licenses/jQuery-QueryBuilder-LICENSE PRE-CREATION 
>   LICENSE 9722907 
>   dashboardv2/gruntfile.js cf076b6 
>   dashboardv2/package.json 8924f71 
>   dashboardv2/public/css/scss/form.scss 3ee94f5 
>   dashboardv2/public/css/scss/override.scss 2852f80 
>   dashboardv2/public/css/scss/search.scss 8c3dbec 
>   dashboardv2/public/index.html 5fff304 
>   dashboardv2/public/js/collection/VSearchList.js 6a84943 
>   dashboardv2/public/js/collection/VTagList.js 9304858 
>   dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.js bb930fb 
>   dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.min.css e9ec816 
>   dashboardv2/public/js/main.js 3b40451 
>   dashboardv2/public/js/models/VSearch.js 5c3df97 
>   dashboardv2/public/js/models/VTag.js c875d5a 
>   dashboardv2/public/js/router/Router.js f1250e7 
>   dashboardv2/public/js/templates/search/QueryBuilder_tmpl.html PRE-CREATION 
>   dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html a766cdf 
>   dashboardv2/public/js/templates/search/SearchQuery_tmpl.html PRE-CREATION 
>   dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 91f1a67 
>   dashboardv2/public/js/templates/tag/AddTagAttributeView_tmpl.html a7f9146 
>   dashboardv2/public/js/templates/tag/createTagLayoutView_tmpl.html 0491c78 
>   dashboardv2/public/js/utils/Overrides.js b6fc17c 
>   dashboardv2/public/js/utils/UrlLinks.js c692d8d 
>   dashboardv2/public/js/utils/Utils.js 1d614a8 
>   dashboardv2/public/js/views/business_catalog/SideNavLayoutView.js af18540 
>   dashboardv2/public/js/views/entity/CreateEntityLayoutView.js 704062f 
>   dashboardv2/public/js/views/search/QueryBuilderView.js PRE-CREATION 
>   dashboardv2/public/js/views/search/SearchDetailLayoutView.js b22fae8 
>   dashboardv2/public/js/views/search/SearchLayoutView.js 32b82d7 
>   dashboardv2/public/js/views/search/SearchQueryView.js PRE-CREATION 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js 1198809 
>   dashboardv2/public/js/views/tag/TagDetailLayoutView.js 3bb27c3 
>   dashboardv2/public/js/views/tag/TagLayoutView.js a5b5665 
> 
> 
> Diff: https://reviews.apache.org/r/60528/diff/2/
> 
> 
> Testing
> -------
> 
> Performed one round of sanity testing and UI is working fine
> 
> 
> Thanks,
> 
> keval bhatt
> 
>


Re: Review Request 60528: UI : Search using entity and trait attributes

Posted by keval bhatt <kb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60528/
-----------------------------------------------------------

(Updated June 30, 2017, 8:22 a.m.)


Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.


Changes
-------

Missing licenses added


Bugs: ATLAS-1894
    https://issues.apache.org/jira/browse/ATLAS-1894


Repository: atlas


Description
-------

In basic search user can search based on attribute condition.


Diffs (updated)
-----

  3party-licenses/bootstrap-datepicker-LICENSE 3fd94fa 
  3party-licenses/bootstrap-daterangepicker-LICENSE PRE-CREATION 
  3party-licenses/jQuery-QueryBuilder-LICENSE PRE-CREATION 
  LICENSE 9722907 
  dashboardv2/gruntfile.js cf076b6 
  dashboardv2/package.json 8924f71 
  dashboardv2/public/css/scss/form.scss 3ee94f5 
  dashboardv2/public/css/scss/override.scss 2852f80 
  dashboardv2/public/css/scss/search.scss 8c3dbec 
  dashboardv2/public/index.html 5fff304 
  dashboardv2/public/js/collection/VSearchList.js 6a84943 
  dashboardv2/public/js/collection/VTagList.js 9304858 
  dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.js bb930fb 
  dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.min.css e9ec816 
  dashboardv2/public/js/main.js 3b40451 
  dashboardv2/public/js/models/VSearch.js 5c3df97 
  dashboardv2/public/js/models/VTag.js c875d5a 
  dashboardv2/public/js/router/Router.js f1250e7 
  dashboardv2/public/js/templates/search/QueryBuilder_tmpl.html PRE-CREATION 
  dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html a766cdf 
  dashboardv2/public/js/templates/search/SearchQuery_tmpl.html PRE-CREATION 
  dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 91f1a67 
  dashboardv2/public/js/templates/tag/AddTagAttributeView_tmpl.html a7f9146 
  dashboardv2/public/js/templates/tag/createTagLayoutView_tmpl.html 0491c78 
  dashboardv2/public/js/utils/Overrides.js b6fc17c 
  dashboardv2/public/js/utils/UrlLinks.js c692d8d 
  dashboardv2/public/js/utils/Utils.js 1d614a8 
  dashboardv2/public/js/views/business_catalog/SideNavLayoutView.js af18540 
  dashboardv2/public/js/views/entity/CreateEntityLayoutView.js 704062f 
  dashboardv2/public/js/views/search/QueryBuilderView.js PRE-CREATION 
  dashboardv2/public/js/views/search/SearchDetailLayoutView.js b22fae8 
  dashboardv2/public/js/views/search/SearchLayoutView.js 32b82d7 
  dashboardv2/public/js/views/search/SearchQueryView.js PRE-CREATION 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js 1198809 
  dashboardv2/public/js/views/tag/TagDetailLayoutView.js 3bb27c3 
  dashboardv2/public/js/views/tag/TagLayoutView.js a5b5665 


Diff: https://reviews.apache.org/r/60528/diff/2/

Changes: https://reviews.apache.org/r/60528/diff/1-2/


Testing
-------

Performed one round of sanity testing and UI is working fine


Thanks,

keval bhatt