You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by joyyoj <gi...@git.apache.org> on 2014/07/31 17:55:36 UTC
[GitHub] spark pull request: [SPARK-2379] Fix the bug that streaming's rece...
GitHub user joyyoj opened a pull request:
https://github.com/apache/spark/pull/1694
[SPARK-2379] Fix the bug that streaming's receiver may fall into a dead loop
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joyyoj/spark SPARK-2379
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/1694.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1694
----
commit f4660c5cb41d9b5ef737b38e7e38abf3b2f2e31c
Author: joyyoj <su...@gmail.com>
Date: 2014-06-03T13:15:11Z
[SPARK-1998] SparkFlumeEvent with body bigger than 1020 bytes are not read properly
commit 3f4a6022b3e54a69a8b67729b2ce3dbbf0d7c85b
Author: joyyoj <su...@gmail.com>
Date: 2014-07-06T14:27:47Z
Merge remote-tracking branch 'remotes/apache/master'
commit 22e7821e439ec3304c784217cbde94ae6db1b75e
Author: joyyoj <su...@gmail.com>
Date: 2014-07-31T15:08:51Z
Merge remote-tracking branch 'apache/master'
commit d73790d152c7b0c1c501cfae69f0945e70e47d7b
Author: joyyoj <su...@gmail.com>
Date: 2014-07-31T15:53:39Z
SPARK-2379 Fix the bug that streaming's receiver may fall into a dead loop
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2379] Fix the bug that streaming's rece...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1694#issuecomment-50779088
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2379] Fix the bug that streaming's rece...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1694#issuecomment-50814205
QA results for PR 1694:<br>- This patch PASSES unit tests.<br>- This patch merges cleanly<br>- This patch adds no public classes<br><br>For more information see test ouptut:<br>https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17598/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2379] Fix the bug that streaming's rece...
Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1694#discussion_r15664072
--- Diff: streaming/src/main/scala/org/apache/spark/streaming/receiver/ReceiverSupervisor.scala ---
@@ -138,7 +138,7 @@ private[streaming] abstract class ReceiverSupervisor(
onReceiverStop(message, error)
} catch {
case t: Throwable =>
- stop("Error stopping receiver " + streamId, Some(t))
+ logError("Error stopping receiver " + streamId + t.getStackTraceString)
--- End diff --
Can you also add reportError() so that this error gets reported to the driver? Its easier to debug when all the error gets reported to the driver.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2379] Fix the bug that streaming's rece...
Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1694#issuecomment-50932374
@joyyoj I am just gonna merge this and deal with reportError later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2379] Fix the bug that streaming's rece...
Posted by joyyoj <gi...@git.apache.org>.
Github user joyyoj commented on the pull request:
https://github.com/apache/spark/pull/1694#issuecomment-51147129
@tdas Thanks for reminding me to add reportError, i didn't notice your reply before. It's a good idea to add it in this patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2379] Fix the bug that streaming's rece...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1694
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2379] Fix the bug that streaming's rece...
Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1694#issuecomment-50807001
Jenkins, this is ok to test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2379] Fix the bug that streaming's rece...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1694#issuecomment-50807516
QA tests have started for PR 1694. This patch merges cleanly. <br>View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17598/consoleFull
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: [SPARK-2379] Fix the bug that streaming's rece...
Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1694#issuecomment-51153366
Well, I have merged this patch already, in an attempt to squeeze it in 1.1 release. If you open another patch to make the change, I can try squeezing that too. Thanks for detecting and fixing this bug!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-2379] Fix the bug that streaming's rece...
Posted by alexanderdai <gi...@git.apache.org>.
Github user alexanderdai commented on the pull request:
https://github.com/apache/spark/pull/1694#issuecomment-50844613
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---