You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2009/05/13 20:17:11 UTC
svn commit: r774463 - in
/jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action:
CheckDirty.java Remove.java
Author: sebb
Date: Wed May 13 18:17:09 2009
New Revision: 774463
URL: http://svn.apache.org/viewvc?rev=774463&view=rev
Log:
Tweaks/add TODO
Modified:
jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/CheckDirty.java
jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/Remove.java
Modified: jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/CheckDirty.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/CheckDirty.java?rev=774463&r1=774462&r2=774463&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/CheckDirty.java (original)
+++ jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/CheckDirty.java Wed May 13 18:17:09 2009
@@ -40,7 +40,7 @@
public class CheckDirty extends AbstractAction implements HashTreeTraverser, ActionListener {
private static final Logger log = LoggingManager.getLoggerForClass();
- private Map previousGuiItems;
+ private final Map previousGuiItems;
private boolean checkMode = false;
Modified: jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/Remove.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/Remove.java?rev=774463&r1=774462&r2=774463&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/Remove.java (original)
+++ jakarta/jmeter/trunk/src/core/org/apache/jmeter/gui/action/Remove.java Wed May 13 18:17:09 2009
@@ -56,6 +56,7 @@
}
public void doAction(ActionEvent e) {
+ // TODO - removes the nodes from the CheckDirty map - should it be done later, in case some can't be removed?
ActionRouter.getInstance().actionPerformed(new ActionEvent(e.getSource(), e.getID(), ActionNames.CHECK_REMOVE));
GuiPackage guiPackage = GuiPackage.getInstance();
JMeterTreeNode[] nodes = guiPackage.getTreeListener().getSelectedNodes();
@@ -68,7 +69,7 @@
guiPackage.updateCurrentGui();
}
- public static void removeNode(JMeterTreeNode node) {
+ private static void removeNode(JMeterTreeNode node) {
TestElement testElement = node.getTestElement();
if (testElement.canRemove()) {
GuiPackage.getInstance().getTreeModel().removeNodeFromParent(node);
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org