[GitHub] [incubator-pegasus] empiredan commented on a diff in pull request #1237: feat(new_metrics): support filters for selected metric fields in response

[GitBox <gi...@apache.org>]

empiredan commented on code in PR #1237:
URL: https://github.com/apache/incubator-pegasus/pull/1237#discussion_r1020078147


##########
src/utils/metrics.h:
##########
@@ -131,6 +132,61 @@
 
 namespace dsn {
 
+using metric_fields_type = std::unordered_set<std::string>;
+
+// This struct includes a set of filters for both entities and metrics requested by client.
+struct metric_filters
+{
+    using fields_filter_fn = std::function<bool(const std::string &)>;
+
+    // According to the parameters requested by client, this function will filter metric
+    // fields that will be put in the response. `with_metric_fields` includes all the metric
+    // fields that are wanted by client; on the contrary, once client wants all except some
+    // metric fields, it could specify them in `without_metric_fields`.

Review Comment:
   > Since there are dozens of metrics, what's the use case of specify 'without_metric_fields'?
   
   For example, `without_metric_fields` will be useful while we request for all fields except `desc`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org