You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/16 08:31:57 UTC

[GitHub] [kafka] PhilHardwick commented on pull request #10921: KAFKA-13096: Ensure queryable store providers is up to date after adding stream thread

PhilHardwick commented on pull request #10921:
URL: https://github.com/apache/kafka/pull/10921#issuecomment-881274661


   Closed by accident there^
   
   Thanks @ableegoldman for creating a JIRA ticket for this. I've updated the PR with a test for querying the stores after a thread is removed. I've currently gone for the QueryStoreProvider having it's own ArrayList and Kafka Streams calling the add/remove methods on QueryStoreProvider. But I'm also happy to change it to being an ArrayList that KafkaStreams owns and QueryStoreProvider just holds the reference to that (I guess either way, when adding or removing a thread you would need to remember to update either the ArrayList or the QueryStoreProvider).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org