You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Ranxy (via GitHub)" <gi...@apache.org> on 2023/09/28 06:59:34 UTC
[GitHub] [incubator-opendal] Ranxy opened a new pull request, #3201: feat(bindings/ocaml): support layer
Ranxy opened a new pull request, #3201:
URL: https://github.com/apache/incubator-opendal/pull/3201
Introduced layer in OCaml binding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ranxy commented on pull request #3201: feat(bindings/ocaml): support layer
Posted by "Ranxy (via GitHub)" <gi...@apache.org>.
Ranxy commented on PR #3201:
URL: https://github.com/apache/incubator-opendal/pull/3201#issuecomment-1738705629
> > It is not a simple matter to implement such a universal OCaml layer.
>
> Yes, I'm quite hesitant about adding this in OCaml. How about finishing the release and gaining our first user? We can improve the ocaml binding based on real users feedback.
Okay, let's put aside the layer and solve the release problem first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ranxy commented on pull request #3201: feat(bindings/ocaml): support layer
Posted by "Ranxy (via GitHub)" <gi...@apache.org>.
Ranxy commented on PR #3201:
URL: https://github.com/apache/incubator-opendal/pull/3201#issuecomment-1738674864
> > but I'm sorry I don't fully understand what wrapper you are referring to.
>
> My general idea is that we should not expose rust layers to ocaml side directly. Instead, we should implement something called `OcamlLayer` in which we will call ocaml code. So users can integrate with ocaml's native logging/metrics/tracing libs.
>
> The call path will be like:
>
> ```
> ocaml: op.read()
> |
> v
> rust: call inner rust code
> |
> v
> rust: call ocaml layer
> |
> V
> ocaml：call users provided layer (for example, a logging layer implemented by https://github.com/dbuenzli/logs)
> |
> v
> rust: return value to ocaml binding
> |
> v
> ocaml: return value to user
> ```
Understand what you mean, It is not a simple matter to implement such a universal OCaml layer. This may require implementing a layer for ffi callback in rust.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ranxy commented on pull request #3201: feat(bindings/ocaml): support layer
Posted by "Ranxy (via GitHub)" <gi...@apache.org>.
Ranxy commented on PR #3201:
URL: https://github.com/apache/incubator-opendal/pull/3201#issuecomment-1738634469
> Thanks for the PR, but bindings should not expose layers AS-IS. Instead, they should provide their own wrapper.
>
> Some layers could be enabled by default like retry and blocking.
It is easy to add retry to the layer enabled by default, but I'm sorry I don't fully understand what wrapper you are referring to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #3201: feat(bindings/ocaml): support layer
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3201:
URL: https://github.com/apache/incubator-opendal/pull/3201#issuecomment-1738706745
> Okay, let's put aside the layer and solve the release problem first.
Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Ranxy closed pull request #3201: feat(bindings/ocaml): support layer
Posted by "Ranxy (via GitHub)" <gi...@apache.org>.
Ranxy closed pull request #3201: feat(bindings/ocaml): support layer
URL: https://github.com/apache/incubator-opendal/pull/3201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #3201: feat(bindings/ocaml): support layer
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3201:
URL: https://github.com/apache/incubator-opendal/pull/3201#issuecomment-1738687873
> It is not a simple matter to implement such a universal OCaml layer.
Yes, I'm quite hesitant about adding this in OCaml. How about finishing the release and gaining our first user? We can improve the ocaml binding based on real users feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #3201: feat(bindings/ocaml): support layer
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #3201:
URL: https://github.com/apache/incubator-opendal/pull/3201#issuecomment-1738645174
> but I'm sorry I don't fully understand what wrapper you are referring to.
My general idea is that we should not expose rust layers to ocaml side directly. Instead, we should implement something called `OcamlLayer` in which we will call ocaml code. So users can integrate with ocaml's native logging/metrics/tracing libs.
The call path will be like:
```
ocaml: op.read()
|
v
rust: call inner rust code
|
v
rust: call ocaml layer
|
V
ocaml：call users provided layer implement (like https://github.com/dbuenzli/logs)
|
v
rust: return value to ocaml binding
|
v
ocaml: return value to user
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org