You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/04/19 23:16:00 UTC

[kudu-CR] Fix use after free in RowSetTree

Hello Adar Dembo, Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/2816

to review the following change.

Change subject: Fix use after free in RowSetTree
......................................................................

Fix use after free in RowSetTree

This fixes a use after free bug which only causes issues on OS X. libstdcxx's
ref-counted strings on libstdc++ hide the bug by not destructing the stack
allocated string, because it had been copied elsewhere in the meantime.

Change-Id: Id640ec1f1092a28cbba00becebb8ff2e81828b77
---
M src/kudu/tablet/rowset_tree.cc
1 file changed, 7 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/2816/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2816
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id640ec1f1092a28cbba00becebb8ff2e81828b77
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>