You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2016/06/21 17:26:39 UTC
[jclouds/jclouds] JCLOUDS-1125: local blobstore list MPUs (#976)
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/976
-- Commit Summary --
* JCLOUDS-1125: local blobstore list MPUs
-- File Changes --
M apis/filesystem/src/test/java/org/jclouds/filesystem/integration/FilesystemBlobIntegrationTest.java (9)
M blobstore/src/main/java/org/jclouds/blobstore/config/LocalBlobStore.java (40)
M blobstore/src/test/java/org/jclouds/blobstore/integration/TransientBlobIntegrationTest.java (9)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/976.patch
https://github.com/jclouds/jclouds/pull/976.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/976
Re: [jclouds/jclouds] JCLOUDS-1125: local blobstore list MPUs (#976)
Posted by Zack Shoylev <no...@github.com>.
Looks good. I will run some more tests on my windows machine tomorrow.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/976#issuecomment-227608847
Re: [jclouds/jclouds] JCLOUDS-1125: local blobstore list MPUs (#976)
Posted by Zack Shoylev <no...@github.com>.
> @@ -100,6 +100,7 @@
>
> @Singleton
> public final class LocalBlobStore implements BlobStore {
> + private static final String MULTIPART_PREFIX = ".mpus-";
Should this be configurable?
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/976/files/c17ea1f76c90433f3c752099b65aef93d201becb#r67974389
Re: [jclouds/jclouds] JCLOUDS-1125: local blobstore list MPUs (#976)
Posted by Zack Shoylev <no...@github.com>.
> @@ -783,24 +784,29 @@ public boolean createContainerInLocation(Location location, String container, Cr
>
> @Override
> public MultipartUpload initiateMultipartUpload(String container, BlobMetadata blobMetadata, PutOptions options) {
> - return MultipartUpload.create(container, blobMetadata.getName(), UUID.randomUUID().toString(),
> + String uploadId = UUID.randomUUID().toString();
> + // create a stub blob
> + Blob blob = blobBuilder(MULTIPART_PREFIX + uploadId + "-" + blobMetadata.getName() + "-0").payload(ByteSource.empty()).build();
The -0 might be confusing. -stub maybe?
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/976/files/c17ea1f76c90433f3c752099b65aef93d201becb#r67974915
Re: [jclouds/jclouds] JCLOUDS-1125: local blobstore list MPUs (#976)
Posted by Andrew Gaul <no...@github.com>.
> @@ -100,6 +100,7 @@
>
> @Singleton
> public final class LocalBlobStore implements BlobStore {
> + private static final String MULTIPART_PREFIX = ".mpus-";
I don't think so; it might be nice to configure MPUs to go into another directory or similar but I don't see much need to change the prefix.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/976/files/c17ea1f76c90433f3c752099b65aef93d201becb#r68353223
Re: [jclouds/jclouds] JCLOUDS-1125: local blobstore list MPUs (#976)
Posted by Andrew Gaul <no...@github.com>.
> @@ -783,24 +784,29 @@ public boolean createContainerInLocation(Location location, String container, Cr
>
> @Override
> public MultipartUpload initiateMultipartUpload(String container, BlobMetadata blobMetadata, PutOptions options) {
> - return MultipartUpload.create(container, blobMetadata.getName(), UUID.randomUUID().toString(),
> + String uploadId = UUID.randomUUID().toString();
> + // create a stub blob
> + Blob blob = blobBuilder(MULTIPART_PREFIX + uploadId + "-" + blobMetadata.getName() + "-0").payload(ByteSource.empty()).build();
Done.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/976/files/c17ea1f76c90433f3c752099b65aef93d201becb#r68353086
Re: [jclouds/jclouds] JCLOUDS-1125: local blobstore list MPUs (#976)
Posted by Zack Shoylev <no...@github.com>.
Ran tests, looks good.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/976#issuecomment-227767581
Re: [jclouds/jclouds] JCLOUDS-1125: local blobstore list MPUs (#976)
Posted by Andrew Gaul <no...@github.com>.
@zack-shoylev Please review. This commit changes the way that multipart uploads are named and makes the approach more similar to S3 which has a separate namespace for MPU.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/976#issuecomment-227567300