You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by paul-guo- <gi...@git.apache.org> on 2016/05/05 07:10:37 UTC
[GitHub] incubator-hawq pull request: HAWQ-711. Integrate libhdfs3 and liby...
GitHub user paul-guo- opened a pull request:
https://github.com/apache/incubator-hawq/pull/638
HAWQ-711. Integrate libhdfs3 and libyarn makefile into hawq
This is based on Liming's work, i.e. commit 1b0e6e2d728b5f4f9da09ecc19dc32c87a9fdc81
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paul-guo-/incubator-hawq master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/638.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #638
----
commit 51293c194c876fbe629e7f374ac417179001a195
Author: Paul Guo <pa...@gmail.com>
Date: 2016-05-05T06:55:20Z
HAWQ-711. Integrate libhdfs3 and libyarn makefile into hawq
This is based on Liming's work, i.e. commit 1b0e6e2d728b5f4f9da09ecc19dc32c87a9fdc81
This patch will make that we do not need to build libhdfs and libyarn seperately before building hawq.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-711. Integrate libhdfs3 and liby...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the pull request:
https://github.com/apache/incubator-hawq/pull/638#issuecomment-221501406
Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-711. Integrate libhdfs3 and liby...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the pull request:
https://github.com/apache/incubator-hawq/pull/638#issuecomment-217758533
I think it is just a workaround solution. HAWQ use autotools but in this pull request, `libyarn` and `libhdfs3` use makefile which is dangerous for portability.
I think a better solution is to write a shell/python script which is transparent to user that could build `libyarn` and `libhdfs3` before building `hawq`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-711. Integrate libhdfs3 and liby...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the pull request:
https://github.com/apache/incubator-hawq/pull/638#issuecomment-217763593
To Huor, I checked the source code. It seems that it is easy to add some Makefile targets for the issues you mentioned. To better track them, I'd leave them to another issue.
To xunzhang, yes, we should do them in configure or make to make the build of libhdfs3 and libyarn transparent to users. Currently doing it in "make pre_config" (dependency of "make all") seems to be better to handle. Maybe I misunderstood your words.
Thanks all.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-711. Integrate libhdfs3 and liby...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/638#issuecomment-217765182
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-711. Integrate libhdfs3 and liby...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- closed the pull request at:
https://github.com/apache/incubator-hawq/pull/638
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-711. Integrate libhdfs3 and liby...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the pull request:
https://github.com/apache/incubator-hawq/pull/638#issuecomment-217765195
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-711. Integrate libhdfs3 and liby...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/638#discussion_r62444174
--- Diff: configure ---
@@ -11461,157 +11427,6 @@ rm -f core conftest.err conftest.$ac_objext \
pgac_args="$pgac_args with_xml_prefix with_xml_exec_prefix enable_xmltest"
CFLAGS="$CFLAGS $XML_CPPFLAGS"
-# libhdfs3
--- End diff --
We do not build libhdfs3 separately now so we do not need to check the dependency.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-711. Integrate libhdfs3 and liby...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the pull request:
https://github.com/apache/incubator-hawq/pull/638#issuecomment-218051802
@paul-guo- plz sync `configure.in` asap. Any problem, ping me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-711. Integrate libhdfs3 and liby...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the pull request:
https://github.com/apache/incubator-hawq/pull/638#issuecomment-217631351
It would be good to support "make unittest" for hawq and its dependencies as we have "make unittest" for libyarn, libhdfs3, pxf and "make unittest-check" for contrib/hawq-hadoop.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-711. Integrate libhdfs3 and liby...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/638#discussion_r62442543
--- Diff: configure ---
@@ -11461,157 +11427,6 @@ rm -f core conftest.err conftest.$ac_objext \
pgac_args="$pgac_args with_xml_prefix with_xml_exec_prefix enable_xmltest"
CFLAGS="$CFLAGS $XML_CPPFLAGS"
-# libhdfs3
--- End diff --
Why delete configure test for libhdfs3 here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---