You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/03/12 00:43:29 UTC
[GitHub] [incubator-mxnet] access2rohit opened a new pull request #20015: [DO NOT MERGE][WIP][v1.8.x][BACKPORT]Stabling CI and making binaries apache compliant
access2rohit opened a new pull request #20015:
URL: https://github.com/apache/incubator-mxnet/pull/20015
## Description ##
Backport PRs #20014(Awaiting merge) #19930 #19974 #19506 #19522
## Checklist ##
### Essentials ###
- [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [x] All changes have test coverage
- [x] Code is well-documented
## Testing ##
Tested on local CD pipeline identical to the one for v1.8.x: https://jenkins.mxnet-ci.amazon-ml.com/job/restricted-mxnet-cd/job/rohit_v1.8.x/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #20015: [v1.8.x][BACKPORT]Stablizing CI and making binaries apache compliant
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #20015:
URL: https://github.com/apache/incubator-mxnet/pull/20015#issuecomment-797977832
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #20015: [DO NOT MERGE][WIP][v1.8.x][BACKPORT]Stabling CI and making binaries apache compliant
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #20015:
URL: https://github.com/apache/incubator-mxnet/pull/20015#issuecomment-797317018
@samskalicky can you review ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #20015: [v1.8.x][BACKPORT]Stablizing CI and making binaries apache compliant
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #20015:
URL: https://github.com/apache/incubator-mxnet/pull/20015#issuecomment-797712366
@samskalicky its already merged in v1.x
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 commented on a change in pull request #20015: [v1.8.x][BACKPORT]Stablizing CI and making binaries apache compliant
Posted by GitBox <gi...@apache.org>.
mseth10 commented on a change in pull request #20015:
URL: https://github.com/apache/incubator-mxnet/pull/20015#discussion_r593795635
##########
File path: cd/utils/artifact_repository.md
##########
@@ -17,7 +17,7 @@
# Artifact Repository - Pushing and Pulling libmxnet
-The artifact repository is an S3 bucket accessible only to restricted Jenkins nodes. It is used to store compiled MXNet artifacts that can be used by downstream CD pipelines to package the compiled libraries for different delivery channels (e.g. DockerHub, PyPI, Maven, etc.). The S3 object keys for the files being posted will be prefixed with the following distinguishing characteristics of the binary: branch, commit id, operating system, variant and dependency linking strategy (static or dynamic). For instance, s3://bucket/73b29fa90d3eac0b1fae403b7583fdd1529942dc/ubuntu16.04/cu92mkl/static/libmxnet.so
+The artifact repository is an S3 bucket accessible only to restricted Jenkins nodes. It is used to store compiled MXNet artifacts that can be used by downstream CD pipelines to package the compiled libraries for different delivery channels (e.g. DockerHub, PyPI, Maven, etc.). The S3 object keys for the files being posted will be prefixed with the following distinguishing characteristics of the binary: branch, commit id, operating system, variant and dependency linking strategy (static or dynamic). For instance, s3://bucket/73b29fa90d3eac0b1fae403b7583fdd1529942dc/ubuntu16.04/cu100/static/libmxnet.so
Review comment:
nit: it's ubuntu18.04 now in s3 folders
##########
File path: ci/docker/Dockerfile.build.ubuntu_gpu_cu112
##########
@@ -0,0 +1,49 @@
+# -*- mode: dockerfile -*-
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+# Dockerfile to run MXNet on Ubuntu 18.04 for GPU
+
+FROM nvidia/cuda:11.2.1-cudnn8-devel-ubuntu18.04
+
+WORKDIR /work/deps
+
+COPY install/requirements /work/
+
+COPY install/ubuntu_core.sh /work/
+RUN /work/ubuntu_core.sh
+
+COPY install/deb_ubuntu_ccache.sh /work/
+RUN /work/deb_ubuntu_ccache.sh
+
+COPY install/ubuntu_python.sh /work/
+COPY install/requirements /work/
Review comment:
remove this, duplicate of line 25
##########
File path: cd/Jenkinsfile_release_job
##########
@@ -42,8 +42,8 @@ pipeline {
// Using string instead of choice parameter to keep the changes to the parameters minimal to avoid
// any disruption caused by different COMMIT_ID values chaning the job parameter configuration on
// Jenkins.
- string(defaultValue: "mxnet_lib", description: "Pipeline to build", name: "RELEASE_JOB_TYPE")
- string(defaultValue: "cpu,native,cu100,cu101,cu102,cu110", description: "Comma separated list of variants", name: "MXNET_VARIANTS")
+ string(defaultValue: "mxnet_lib/static", description: "Pipeline to build", name: "RELEASE_JOB_TYPE")
Review comment:
should be mxnet_lib, we removed "/static" in a previous commit https://github.com/apache/incubator-mxnet/commit/dd4661a12230584dc206b4bf233ede261fa64786#diff-dd43bbf192e508d18e340337cf5a6094e137fba710759718cfbde6cf38e27a54R45
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] access2rohit commented on pull request #20015: [DO NOT MERGE][WIP][v1.8.x][BACKPORT]Stabling CI and making binaries apache compliant
Posted by GitBox <gi...@apache.org>.
access2rohit commented on pull request #20015:
URL: https://github.com/apache/incubator-mxnet/pull/20015#issuecomment-797154361
@samskalicky once this PR merges our binaries will be apache compliant
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on pull request #20015: [v1.8.x][BACKPORT]Stablizing CI and making binaries apache compliant
Posted by GitBox <gi...@apache.org>.
samskalicky commented on pull request #20015:
URL: https://github.com/apache/incubator-mxnet/pull/20015#issuecomment-797665981
@leezu should we upgrade the CI in 1.x to Ubuntu 18 from 16? I thought we were only doing that for master/2.0 and later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20015: [v1.8.x][BACKPORT]Stablizing CI and making binaries apache compliant
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20015:
URL: https://github.com/apache/incubator-mxnet/pull/20015#issuecomment-797977956
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mseth10 merged pull request #20015: [v1.8.x][BACKPORT]Stablizing CI and making binaries apache compliant
Posted by GitBox <gi...@apache.org>.
mseth10 merged pull request #20015:
URL: https://github.com/apache/incubator-mxnet/pull/20015
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org