You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by Rowandjj <gi...@git.apache.org> on 2017/03/13 05:54:18 UTC
[GitHub] incubator-weex pull request #97: remove unnecessary nested frameLayout in em...
GitHub user Rowandjj opened a pull request:
https://github.com/apache/incubator-weex/pull/97
remove unnecessary nested frameLayout in embed
@sospartan
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Rowandjj/incubator-weex 0.11-dev-chuyi
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/97.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #97
----
commit 48b9f55aae19969eabefe358a7a97d95cb43c056
Author: chuyi <ji...@alibaba-inc.com>
Date: 2017-03-13T05:52:32Z
remove unnecessary nested frameLayout in embed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #97: remove unnecessary nested frameLayout in em...
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/97#discussion_r105626238
--- Diff: android/sdk/src/main/java/com/taobao/weex/ui/component/WXEmbed.java ---
@@ -327,9 +331,7 @@ public void onCreated(NestedContainer comp, WXSDKInstance nestedInstance) {
@Override
public void onViewCreated(WXSDKInstance instance, View view) {
- FrameLayout hostView = mComponent.getHostView();
- hostView.removeAllViews();
- hostView.addView(view);
+
--- End diff --
@xkli \u8fd9\u91cc\u5220\u6389\u4f1a\u4e0d\u4f1a\u6709\u95ee\u9898\uff1f
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #97: remove unnecessary nested frameLayout in embed
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/97
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true" data-kind="Error">
1 Error
</th>
</tr>
</thead>
<tbody>
<tr>
<td>:no_entry_sign:</td>
<td data-sticky="false">Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/WXEmbed.java without metion it in commit message.</td>
</tr>
</tbody>
</table>
<p align="right" data-meta="generated_by_danger">
Generated by :no_entry_sign: <a href="http://danger.systems/">danger</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #97: remove unnecessary nested frameLayout in em...
Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/97#discussion_r105813237
--- Diff: android/sdk/src/main/java/com/taobao/weex/ui/component/WXEmbed.java ---
@@ -327,9 +331,7 @@ public void onCreated(NestedContainer comp, WXSDKInstance nestedInstance) {
@Override
public void onViewCreated(WXSDKInstance instance, View view) {
- FrameLayout hostView = mComponent.getHostView();
- hostView.removeAllViews();
- hostView.addView(view);
+
--- End diff --
\u6211\u662f\u8bf4\u8ddf\u964d\u7ea7\u7684\u903b\u8f91\u4f1a\u4e0d\u4f1a\u6709\u51b2\u7a81
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #97: remove unnecessary nested frameLayout in em...
Posted by Rowandjj <gi...@git.apache.org>.
Github user Rowandjj closed the pull request at:
https://github.com/apache/incubator-weex/pull/97
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #97: remove unnecessary nested frameLayout in em...
Posted by xkli <gi...@git.apache.org>.
Github user xkli commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/97#discussion_r105823132
--- Diff: android/sdk/src/main/java/com/taobao/weex/ui/component/WXEmbed.java ---
@@ -327,9 +331,7 @@ public void onCreated(NestedContainer comp, WXSDKInstance nestedInstance) {
@Override
public void onViewCreated(WXSDKInstance instance, View view) {
- FrameLayout hostView = mComponent.getHostView();
- hostView.removeAllViews();
- hostView.addView(view);
+
--- End diff --
\u5220\u9664\u4f1a\u6709\u5f71\u54cd\uff0c\u624b\u6dd8\u91cc\u9762\u4f1a\u52a8\u6001\u6dfb\u52a0progressbar.\u6e32\u67d3\u5b8c\u6210\u540e\u5c31\u7528\u8fd9\u4e2a\u65b9\u6cd5\u628aprogressBar\u9690\u85cf\u7684\u3002
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #97: remove unnecessary nested frameLayout in em...
Posted by Rowandjj <gi...@git.apache.org>.
Github user Rowandjj commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/97#discussion_r105810445
--- Diff: android/sdk/src/main/java/com/taobao/weex/ui/component/WXEmbed.java ---
@@ -327,9 +331,7 @@ public void onCreated(NestedContainer comp, WXSDKInstance nestedInstance) {
@Override
public void onViewCreated(WXSDKInstance instance, View view) {
- FrameLayout hostView = mComponent.getHostView();
- hostView.removeAllViews();
- hostView.addView(view);
+
--- End diff --
\u521b\u5efa\u51fa\u6765\u7684view\u4f1a\u81ea\u52a8\u52a0\u5230renderContainer(\u5373hostView)\u4e0a\u5427
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---